Cancel client auth requests when not promptable.

chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h

Index: chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h
diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h
index aacdafe882a79e1c1b1cfbc97f937e0ac59e6b03..0ab759f21493d6ddfcc2aea957baaa31b2f39fe1 100644
--- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h
+++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.h
@@ -18,6 +18,7 @@
 
 namespace content {
 class BrowserContext;
+class ClientCertificateDelegate;
 }
 
 class ConstrainedWindowMac;
@@ -41,13 +42,16 @@ class SSLClientAuthObserverCocoaBridge;
   NSRect oldSheetFrame_;
   // A copy of the sheet's |autoresizesSubviews| flag to restore on show.
   BOOL oldResizesSubviews_;
+  // True if the certificate selection has been made.
+  BOOL certificateSelected_;

[Ryan Sleevi, 2015/02/25 06:31:36]

I found this a little confusing, and was a cause of concern.

That is, I expected it to only be true if a certificate was positively selected,
but it's also true if the user clicks cancel (e.g. declining to select), because
then we affirmatively return that the user chose _no_ certificate.

It's only false if the sheet ends abnormally.

I'm bad at naming, and suspect you'll have a better expression for this, but
perhaps userResponded or something to indicate it's a user action (vs indirect
through the closing of the tab)?

[davidben, 2015/02/26 18:09:41]

userResponded_ SGTM. Renamed to that and switched up the code to actually match
that names.

 }
 
 @property (readonly, nonatomic) SFChooseIdentityPanel* panel;
 
 - (id)initWithBrowserContext:(const content::BrowserContext*)browserContext
              certRequestInfo:(net::SSLCertRequestInfo*)certRequestInfo
-                    callback:(const chrome::SelectCertificateCallback&)callback;
+                    delegate:(scoped_ptr<content::ClientCertificateDelegate>)
+                                 delegate;
 - (void)displayForWebContents:(content::WebContents*)webContents;
 - (void)closeWebContentsModalDialog;