net/url_request/url_request.cc - Issue 859213006: Cancel client auth requests when not promptable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request.cc

Issue 859213006: Cancel client auth requests when not promptable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@client-auth-cancel-1

Patch Set: extension test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request.cc

diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc

index 132a67d779898c3f88ee105414cb3a4f915fe09b..2a668de3fc6995915dd5e12ff1286e379438c712 100644

--- a/net/url_request/url_request.cc

+++ b/net/url_request/url_request.cc

@@ -158,7 +158,7 @@ void URLRequest::Delegate::OnAuthRequired(URLRequest* request,

void URLRequest::Delegate::OnCertificateRequested(

URLRequest* request,

SSLCertRequestInfo* cert_request_info) {

- request->Cancel();

+ request->CancelWithError(ERR_SSL_CLIENT_AUTH_CERT_NEEDED);

}

void URLRequest::Delegate::OnSSLCertificateError(URLRequest* request,

« content/browser/ssl/ssl_client_auth_handler.cc ('K') | « content/test/data/workers/worker_tls_client_auth.html ('k') | no next file » | no next file with comments »