Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc

Issue 859213006: Cancel client auth requests when not promptable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@client-auth-cancel-1
Patch Set: extension test Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
diff --git a/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc b/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
index 390abd4541c9961e475105ee18a3eda8f1b9c1eb..143ec1b7ed5f1868c1f39fdba3e0f031dcb9c9ec 100644
--- a/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
+++ b/chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
@@ -13,6 +13,7 @@
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/interactive_test_utils.h"
#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/browser/client_certificate_delegate.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test_utils.h"
#include "net/base/request_priority.h"
@@ -73,9 +74,7 @@ class SSLClientCertificateSelectorTest : public InProcessBrowserTest {
browser()->tab_strip_model()->GetActiveWebContents());
selector_ = new SSLClientCertificateSelector(
browser()->tab_strip_model()->GetActiveWebContents(),
- auth_requestor_->cert_request_info_,
- base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
- auth_requestor_));
+ auth_requestor_->cert_request_info_, auth_requestor_->CreateDelegate());
selector_->Init();
EXPECT_EQ(mit_davidben_cert_.get(), selector_->GetSelectedCert());
@@ -161,14 +160,12 @@ class SSLClientCertificateSelectorMultiTabTest
selector_1_ = new SSLClientCertificateSelector(
browser()->tab_strip_model()->GetWebContentsAt(1),
auth_requestor_1_->cert_request_info_,
- base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
- auth_requestor_1_));
+ auth_requestor_1_->CreateDelegate());
selector_1_->Init();
selector_2_ = new SSLClientCertificateSelector(
browser()->tab_strip_model()->GetWebContentsAt(2),
auth_requestor_2_->cert_request_info_,
- base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
- auth_requestor_2_));
+ auth_requestor_2_->CreateDelegate());
selector_2_->Init();
EXPECT_EQ(2, browser()->tab_strip_model()->active_index());
@@ -237,8 +234,7 @@ class SSLClientCertificateSelectorMultiProfileTest
selector_1_ = new SSLClientCertificateSelector(
browser_1_->tab_strip_model()->GetActiveWebContents(),
auth_requestor_1_->cert_request_info_,
- base::Bind(&SSLClientAuthRequestorMock::CertificateSelected,
- auth_requestor_1_));
+ auth_requestor_1_->CreateDelegate());
selector_1_->Init();
EXPECT_EQ(mit_davidben_cert_.get(), selector_1_->GetSelectedCert());
@@ -283,7 +279,7 @@ class SSLClientCertificateSelectorMultiProfileTest
IN_PROC_BROWSER_TEST_F(SSLClientCertificateSelectorTest, MAYBE_SelectNone) {
- EXPECT_CALL(*auth_requestor_.get(), CertificateSelected(NULL));
+ EXPECT_CALL(*auth_requestor_.get(), CancelCertificateSelection());
// Let the mock get checked on destruction.
}

Powered by Google App Engine
This is Rietveld 408576698