chrome/browser/ui/views/ssl_client_certificate_selector.h - Issue 859213006: Cancel client auth requests when not promptable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/ssl_client_certificate_selector.h

Issue 859213006: Cancel client auth requests when not promptable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@client-auth-cancel-1

Patch Set: extension test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/xhr_apitest.cc ('K') | « chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm ('k') | chrome/browser/ui/views/ssl_client_certificate_selector.cc » ('j') | content/browser/loader/resource_loader_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/ssl_client_certificate_selector.h

diff --git a/chrome/browser/ui/views/ssl_client_certificate_selector.h b/chrome/browser/ui/views/ssl_client_certificate_selector.h

index de4fbed4bffbf4aa25163267776bff05652bbe0c..62662261e0249f6f575c847e90817e64e83132a3 100644

--- a/chrome/browser/ui/views/ssl_client_certificate_selector.h

+++ b/chrome/browser/ui/views/ssl_client_certificate_selector.h

@@ -41,7 +41,7 @@ class SSLClientCertificateSelector : public SSLClientAuthObserver,

SSLClientCertificateSelector(

content::WebContents* web_contents,

const scoped_refptr<net::SSLCertRequestInfo>& cert_request_info,

- const chrome::SelectCertificateCallback& callback);

+ scoped_ptr<content::ClientCertificateDelegate> delegate);

~SSLClientCertificateSelector() override;

void Init();

@@ -58,6 +58,7 @@ class SSLClientCertificateSelector : public SSLClientAuthObserver,

bool IsDialogButtonEnabled(ui::DialogButton button) const override;

bool Cancel() override;

bool Accept() override;

+ bool Close() override;

views::View* GetInitiallyFocusedView() override;

views::View* CreateExtraView() override;

ui::ModalType GetModalType() const override;