content/test/data/workers/worker_tls_client_auth.html - Issue 859213006: Cancel client auth requests when not promptable.

Side by Side Diff: content/test/data/workers/worker_tls_client_auth.html

Issue 859213006: Cancel client auth requests when not promptable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@client-auth-cancel-1

Patch Set: mmenke comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2

	3 <head>

	4 <title>Worker TLS Client Auth Test</title>

	5

	6 <script src="worker_utils.js"></script>

	7

	8 <script>

	9

	10 var url = decodeURIComponent(/url=([^;]*)/.exec(location.search)[1]);
	mmenke 2015/02/17 19:50:14 The tests really use ";" and not "&" to separate a The tests really use ";" and not "&" to separate arguments? davidben 2015/02/18 22:31:45 Switched it to & since that's a bit more standard. Show quoted text On 2015/02/17 19:50:14, mmenke wrote: > The tests really use ";" and not "&" to separate arguments? Switched it to & since that's a bit more standard. (FWIW, I think CGI scripts normally accept both.) Someday we'll have this thing, but Chrome doesn't have an implementation yet: https://url.spec.whatwg.org/#interface-urlsearchparams Actually, it looks like that thing as spec'd only splits on &, so let's stick with that.
	11 var worker = getWorker("worker_common.js");

	12 worker.onmessage = function(ev) {

	13 if (ev.data == "done")

	14 onSuccess();

	15 };

	16 worker.postMessage("tls-client-auth " + url);
	mmenke 2015/02/17 19:50:14 Could we have some comments here... "tls-client-au Could we have some comments here... "tls-client-auth" doesn't seem to appear in worker_common.js, but searching for "tls-client-auth" and "worker" doesn't produce anything, so I have no idea what this does. davidben 2015/02/18 22:31:45 Hrm? It's in worker_common.js. I added it. https: Show quoted text On 2015/02/17 19:50:14, mmenke wrote: > Could we have some comments here... "tls-client-auth" doesn't seem to appear in > worker_common.js, but searching for "tls-client-auth" and "worker" doesn't > produce anything, so I have no idea what this does. Hrm? It's in worker_common.js. I added it. https://codereview.chromium.org/859213006/diff/320001/content/test/data/worke... mmenke 2015/02/19 21:24:35 Oops...Forgot to remove that comment once I found Show quoted text On 2015/02/18 22:31:45, David Benjamin wrote: > On 2015/02/17 19:50:14, mmenke wrote: > > Could we have some comments here... "tls-client-auth" doesn't seem to appear > in > > worker_common.js, but searching for "tls-client-auth" and "worker" doesn't > > produce anything, so I have no idea what this does. > > Hrm? It's in worker_common.js. I added it. > > https://codereview.chromium.org/859213006/diff/320001/content/test/data/worke... Oops...Forgot to remove that comment once I found it.
	17 </script>

	18 </head>

	19

	20 <body>

	21 <div id=statusPanel></div>
	mmenke 2015/02/17 19:50:14 Per HTML style guide, names should be all lower ca Per HTML style guide, names should be all lower case (https://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=C...) davidben 2015/02/18 22:31:45 I copied it from a different file. Unfortunately t Show quoted text On 2015/02/17 19:50:14, mmenke wrote: > Per HTML style guide, names should be all lower case > (https://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=C...) I copied it from a different file. Unfortunately the JS code in that test assumes it's capital. (Probably copied over from Blink.) https://code.google.com/p/chromium/codesearch#chromium/src/content/test/data/...
	22 </body>

	23 </html>

OLD	NEW

« content/public/browser/client_certificate_delegate.h ('K') | « content/test/data/workers/worker_common.js ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »