Issue 859103002: Fix skydb gdb_attach for non-android configs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 859103002: Fix skydb gdb_attach for non-android configs (Closed)

Created:
5 years, 11 months ago by eseidel

Modified:
5 years, 11 months ago

Reviewers:
qsr, abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix skydb gdb_attach for non-android configs I dumped a bunch of android-specific goop into gdb_attach in my previous commit. This fixes that. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4d253b98d998f3c11d128986dbc8a48fc5aa2d4b

Patch Set 1 #

Total comments: 1

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -33 lines)			Patch
	M	sky/tools/skydb	View		4 chunks	+50 lines, -33 lines	1 comment	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

eseidel

Committed patchset #1 (id:1) manually as 4d253b98d998f3c11d128986dbc8a48fc5aa2d4b (presubmit successful).

5 years, 11 months ago (2015-01-20 22:55:41 UTC) #5

qsr

5 years, 11 months ago (2015-01-21 09:00:49 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/859103002/diff/1/sky/tools/skydb
File sky/tools/skydb (right):

https://codereview.chromium.org/859103002/diff/1/sky/tools/skydb#newcode439
sky/tools/skydb:439: if 'remote_sky_server_port' in self.pids:
Shouldn't you have some more explicit test for detecting android? It seems weird
to rely on this?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages