Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 859073002: Remove use_system_openssl. (Closed)

Created:
5 years, 11 months ago by davidben
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use_system_openssl. Since the BoringSSL switch, this cannot possibly work. (There isn't an openssl.gyp to swap out anyway.) BUG=none Committed: https://crrev.com/2b60792760a1291c50594f213a0bc5e71d020e4d Cr-Commit-Position: refs/heads/master@{#312452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
D build/linux/unbundle/openssl.gyp View 1 chunk +0 lines, -25 lines 0 comments Download
M build/linux/unbundle/replace_gyp_files.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
davidben
5 years, 11 months ago (2015-01-20 18:31:45 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 11 months ago (2015-01-20 19:16:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859073002/1
5 years, 11 months ago (2015-01-20 19:23:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37072) Try jobs failed on following ...
5 years, 11 months ago (2015-01-20 19:31:06 UTC) #7
davidben
+scottmg for build/OWNERS
5 years, 11 months ago (2015-01-20 19:32:43 UTC) #9
scottmg
lgtm
5 years, 11 months ago (2015-01-20 21:09:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859073002/1
5 years, 11 months ago (2015-01-20 21:11:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37072)
5 years, 11 months ago (2015-01-20 21:12:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859073002/1
5 years, 11 months ago (2015-01-21 16:57:23 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 20:53:21 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 20:54:27 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b60792760a1291c50594f213a0bc5e71d020e4d
Cr-Commit-Position: refs/heads/master@{#312452}

Powered by Google App Engine
This is Rietveld 408576698