Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1724)

Issue 85903002: Revert of Generic version of caching cc switches to avoid searching of switches... (Closed)

Created:
7 years ago by Roger Tawa OOO till Jul 10th
Modified:
7 years ago
CC:
chromium-reviews, cc-bugs_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -65 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M cc/base/switches.cc View 1 chunk +39 lines, -64 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Roger Tawa OOO till Jul 10th
Created Revert of Generic version of caching cc switches to avoid searching of switches on ...
7 years ago (2013-11-25 15:01:04 UTC) #1
sivag
On 2013/11/25 15:01:04, Roger Tawa wrote: > Created Revert of Generic version of caching cc ...
7 years ago (2013-11-25 15:23:07 UTC) #2
Tom Hudson
You created a static object at file-level scope. That's a no-no; it causes severe start-up ...
7 years ago (2013-11-25 15:43:18 UTC) #3
vivekg
On 2013/11/25 15:43:18, Tom Hudson wrote: > You created a static object at file-level scope. ...
7 years ago (2013-11-25 15:49:11 UTC) #4
tfarina
Not sure if it happens in this case, but base/ has LazyInstance API. You may ...
7 years ago (2013-11-26 15:34:28 UTC) #5
danakj
7 years ago (2013-11-26 15:57:35 UTC) #6
On 2013/11/25 15:43:18, Tom Hudson wrote:
> You created a static object at file-level scope. That's a no-no; it causes
> severe start-up time hits on some platforms.
> We should have caught this in review of the initial patch. :(

Sorry for missing this, I thought a POD struct would be the same as a POD bool,
but I guess I mixed that up.

Powered by Google App Engine
This is Rietveld 408576698