Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 859023002: [WebCrypto] Renamed rsa-ssa-* tests to rsassa-pkcs1-v1_5-* (Closed)

Created:
5 years, 11 months ago by Habib Virji
Modified:
5 years, 11 months ago
Reviewers:
eroman
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[WebCrypto] Renamed rsa-ssa-* tests to rsassa-pkcs1-v1_5-* Renamed rsa-ssa-* tests to rsassa-pkcs1-v1_5-*. BUG=441024 R=eroman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189022

Patch Set 1 #

Patch Set 2 : Renamed from rsa-ssa to rsassa-pkcs1-v1_5 #

Patch Set 3 : Remove parseAlgorithm from the filename #

Patch Set 4 : Updated to latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -110 lines) Patch
D LayoutTests/crypto/subtle/rsa-ssa-generateKey-failures.html View 1 2 3 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/crypto/subtle/rsa-ssa-generateKey-failures-expected.txt View 1 2 3 1 chunk +0 lines, -39 lines 0 comments Download
A + LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-generateKey-failures.html View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-generateKey-failures-expected.txt View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Habib Virji
5 years, 11 months ago (2015-01-22 15:44:19 UTC) #1
eroman
Thanks for making this change. However could you do the opposite name change? rsa-ssa --> ...
5 years, 11 months ago (2015-01-23 20:41:38 UTC) #2
Habib Virji
Thanks eroman, did the changes. Previous change was to keep it consistent with the unit ...
5 years, 11 months ago (2015-01-26 11:50:10 UTC) #5
eroman
Can you also address 441022 at the same time, and rename it to: rsassa-pkcs1-v1_5-generateKey-failures.html (in ...
5 years, 11 months ago (2015-01-26 20:28:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/859023002/60001
5 years, 11 months ago (2015-01-27 10:07:16 UTC) #8
Habib Virji
Thanks, Updated. I did update this file in 441022 but this branch was not updated. ...
5 years, 11 months ago (2015-01-27 10:09:00 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 11:17:29 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189022

Powered by Google App Engine
This is Rietveld 408576698