Make stencil buffers uncached for uncached render target textures

src/gpu/GrGpu.h

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrGpu_DEFINED
 #define GrGpu_DEFINED
 
@@ skipping 460 matching lines @@
                                       int left, int top, int width, int height,
                                       GrPixelConfig config, const void* buffer,
                                       size_t rowBytes) = 0;
 
     // overridden by backend-specific derived class to perform the resolve
     virtual void onResolveRenderTarget(GrRenderTarget* target) = 0;
 
     // width and height may be larger than rt (if underlying API allows it).
     // Should attach the SB to the RT. Returns false if compatible sb could
     // not be created.
-    virtual bool createStencilBufferForRenderTarget(GrRenderTarget*, int width, int height) = 0;
+    virtual bool createStencilBufferForRenderTarget(GrRenderTarget*, bool budgeted,

[reed1, 2015/01/20 13:54:36]

Why not keep the enum that was created for this, rather than just a bool (which
is slightly harder to understand at a call-site)?

[Kimmo Kinnunen, 2015/01/20 14:05:48]

So it's consistent with the call that does the same thing with the texture.

[bsalomon, 2015/01/21 14:18:18]

I'm slightly hesitant to start depending on an enum from SkSurface all over the
gpu code. My pref is to leave it as a bool for now and perhaps the Budgeted enum
should graduate from the school of SkSurface to be in a pervasive Sk header in
the future (e.g. SkTypes.h) in a future CL. I'll be adding more Budgeted params
soon and can look at doing that.

+                                                    int width, int height) = 0;
 
     // attaches an existing SB to an existing RT.
     virtual bool attachStencilBufferToRenderTarget(GrStencilBuffer*, GrRenderTarget*) = 0;
 
     // clears target's entire stencil buffer to 0
     virtual void clearStencil(GrRenderTarget* target) = 0;
 
     // Given a rt, find or create a stencil buffer and attach it
-    bool attachStencilBufferToRenderTarget(GrRenderTarget* target);
+    bool attachStencilBufferToRenderTarget(GrRenderTarget* target, bool budgeted);
 
     virtual void didAddGpuTraceMarker() = 0;
     virtual void didRemoveGpuTraceMarker() = 0;
 
     void resetContext() {
         this->onResetContext(fResetBits);
         fResetBits = 0;
         ++fResetTimestamp;
     }
 
@@ skipping 11 matching lines @@
     int                                                                 fGpuTraceMarkerCount;
     GrTraceMarkerSet                                                    fActiveTraceMarkers;
     GrTraceMarkerSet                                                    fStoredTraceMarkers;
     // The context owns us, not vice-versa, so this ptr is not ref'ed by Gpu.
     GrContext*                                                          fContext;
 
     typedef SkRefCnt INHERITED;
 };
 
 #endif