Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 8589003: Add OVERRIDE to jingle/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
Reviewers:
akalin
CC:
chromium-reviews
Visibility:
Public.

Description

Add OVERRIDE to jingle/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110546

Patch Set 1 #

Patch Set 2 : includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -86 lines) Patch
M jingle/glue/channel_socket_adapter.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M jingle/glue/pseudotcp_adapter.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M jingle/glue/pseudotcp_adapter_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M jingle/glue/thread_wrapper.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M jingle/glue/thread_wrapper_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M jingle/notifier/base/chrome_async_socket.h View 1 6 chunks +9 lines, -8 lines 0 comments Download
M jingle/notifier/base/fake_ssl_client_socket.h View 1 2 chunks +18 lines, -17 lines 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M jingle/notifier/base/proxy_resolving_client_socket.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M jingle/notifier/base/task_pump.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M jingle/notifier/base/weak_xmpp_client.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M jingle/notifier/base/xmpp_client_socket_factory.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M jingle/notifier/communicator/login.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M jingle/notifier/listener/mediator_thread_impl.h View 1 2 chunks +12 lines, -9 lines 0 comments Download
M jingle/notifier/listener/mediator_thread_mock.h View 2 chunks +12 lines, -9 lines 0 comments Download
M jingle/notifier/listener/push_notifications_listen_task.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M jingle/notifier/listener/push_notifications_send_update_task.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M jingle/notifier/listener/talk_mediator_impl.h View 1 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Avi (use Gerrit)
Need owner approval. Just adding OVERRIDE everywhere.
9 years, 1 month ago (2011-11-16 22:53:38 UTC) #1
akalin
On 2011/11/16 22:53:38, Avi wrote: > Need owner approval. Just adding OVERRIDE everywhere. Don't you ...
9 years, 1 month ago (2011-11-17 02:57:56 UTC) #2
Avi (use Gerrit)
Technically speaking, perhaps. In reality I'm using a clang plugin, and since a few key ...
9 years, 1 month ago (2011-11-17 06:15:29 UTC) #3
akalin
On 2011/11/17 06:15:29, Avi wrote: > Technically speaking, perhaps. In reality I'm using a clang ...
9 years, 1 month ago (2011-11-17 11:25:45 UTC) #4
Avi (use Gerrit)
The Clang plugin we have doesn't alter the code. If you want I can add ...
9 years, 1 month ago (2011-11-17 15:52:25 UTC) #5
akalin
On 2011/11/17 15:52:25, Avi wrote: > The Clang plugin we have doesn't alter the code. ...
9 years, 1 month ago (2011-11-17 18:12:18 UTC) #6
Avi (use Gerrit)
ptal
9 years, 1 month ago (2011-11-17 19:55:30 UTC) #7
akalin
9 years, 1 month ago (2011-11-17 20:03:55 UTC) #8
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698