Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 858843002: Add hook for compiling to JavaScript. (Closed)

Created:
5 years, 11 months ago by ahe
Modified:
5 years, 11 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, Johnni Winther, lukechurch
Target Ref:
refs/remotes/trunk
Visibility:
Public.

Description

Add hook for compiling to JavaScript. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=42984

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused method. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M dart/pkg/dart2js_incremental/lib/server.dart View 1 4 chunks +30 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ahe
5 years, 11 months ago (2015-01-19 10:32:28 UTC) #2
kasperl
LGTM. https://codereview.chromium.org/858843002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart File dart/pkg/dart2js_incremental/lib/server.dart (right): https://codereview.chromium.org/858843002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart#newcode61 dart/pkg/dart2js_incremental/lib/server.dart:61: // Ignored. What kind of exception can happen ...
5 years, 11 months ago (2015-01-19 11:21:04 UTC) #3
ahe
Thank you, Kasper! https://codereview.chromium.org/858843002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart File dart/pkg/dart2js_incremental/lib/server.dart (right): https://codereview.chromium.org/858843002/diff/1/dart/pkg/dart2js_incremental/lib/server.dart#newcode61 dart/pkg/dart2js_incremental/lib/server.dart:61: // Ignored. On 2015/01/19 11:21:04, kasperl ...
5 years, 11 months ago (2015-01-19 11:37:13 UTC) #4
ahe
5 years, 11 months ago (2015-01-19 11:37:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42984 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698