Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 85883002: Provide "freeBuffer()" primitive for testing under ASan. (Closed)

Created:
7 years ago by Dmitry Lomov (no reviews)
Modified:
7 years ago
Reviewers:
Michael Achenbach
CC:
v8-dev, kcc2
Visibility:
Public.

Description

Provide "freeBuffer()" primitive for testing under ASan. R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18091

Patch Set 1 #

Patch Set 2 : Adding missng files #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -22 lines) Patch
M src/bootstrapper.cc View 3 chunks +9 lines, -0 lines 2 comments Download
A + src/extensions/free-buffer-extension.h View 1 2 chunks +8 lines, -7 lines 0 comments Download
A + src/extensions/free-buffer-extension.cc View 1 1 chunk +18 lines, -15 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dmitry Lomov (no reviews)
PTAL. This provides the call to check address sanitizer.
7 years ago (2013-11-25 14:50:42 UTC) #1
Michael Achenbach
Where are free-buffer-extension.*?
7 years ago (2013-11-26 11:20:08 UTC) #2
Dmitry Lomov (no reviews)
On 2013/11/26 11:20:08, machenbach wrote: > Where are free-buffer-extension.*? Oops, sorry. Added.
7 years ago (2013-11-26 13:38:26 UTC) #3
Michael Achenbach
Could you add a test case that exercises this extension? https://codereview.chromium.org/85883002/diff/20001/src/bootstrapper.cc File src/bootstrapper.cc (right): https://codereview.chromium.org/85883002/diff/20001/src/bootstrapper.cc#newcode44 ...
7 years ago (2013-11-26 15:08:57 UTC) #4
Dmitry Lomov (no reviews)
The test for this extension should be a part of chromium's tool sanity tests. https://codereview.chromium.org/85883002/diff/20001/src/bootstrapper.cc ...
7 years ago (2013-11-26 15:22:10 UTC) #5
Michael Achenbach
LGTM
7 years ago (2013-11-26 16:46:37 UTC) #6
Dmitry Lomov (no reviews)
7 years ago (2013-11-27 09:22:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r18091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698