Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 858783003: Add GN file for components/browser_watcher. (Closed)

Created:
5 years, 11 months ago by Slava Chigrin
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GN file for components/browser_watcher. Committed: https://crrev.com/736e6055877ff837c24cfc687a2651d8de26697f Cr-Commit-Position: refs/heads/master@{#312125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
A components/browser_watcher/BUILD.gn View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Slava Chigrin
5 years, 11 months ago (2015-01-18 21:56:13 UTC) #2
Sigurður Ásgeirsson
lgtm - are there Windows builders that build this now?
5 years, 11 months ago (2015-01-19 15:13:29 UTC) #3
Slava Chigrin
On 2015/01/19 15:13:29, Sigurður Ásgeirsson wrote: > lgtm - are there Windows builders that build ...
5 years, 11 months ago (2015-01-19 15:16:30 UTC) #4
Sigurður Ásgeirsson
Thanks - I'm mainly worried that this'll regress before it's ever used, if we can't ...
5 years, 11 months ago (2015-01-19 15:21:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858783003/1
5 years, 11 months ago (2015-01-19 15:44:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-19 16:37:19 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 16:37:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/736e6055877ff837c24cfc687a2651d8de26697f
Cr-Commit-Position: refs/heads/master@{#312125}

Powered by Google App Engine
This is Rietveld 408576698