Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 858743002: Make ThrottleController an ExecutionContext supplement. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
CC:
blink-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make ThrottleController an ExecutionContext supplement. Simplify the FileReader's throttle controller's supplement assocation, turning it into a supplement of ExecutionContext only. R=haraken,nhiroki,kinuko BUG=340515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188795

Patch Set 1 #

Patch Set 2 : check for document-detached state + rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -34 lines) Patch
M Source/core/fileapi/FileReader.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 7 chunks +19 lines, -33 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
Please take a look. Not much in it, but slightly simpler code by changing its ...
5 years, 11 months ago (2015-01-21 21:36:14 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-22 01:54:39 UTC) #3
nhiroki
lgtm
5 years, 11 months ago (2015-01-22 06:11:20 UTC) #4
kinuko
lgtm!
5 years, 11 months ago (2015-01-22 06:32:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858743002/20001
5 years, 11 months ago (2015-01-22 07:52:59 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 07:56:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188795

Powered by Google App Engine
This is Rietveld 408576698