Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: sky/engine/core/rendering/RenderBox.cpp

Issue 858713002: Remove viewportDefiningElement. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/Document.cpp ('k') | sky/engine/core/rendering/RenderLayerScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/RenderBox.cpp
diff --git a/sky/engine/core/rendering/RenderBox.cpp b/sky/engine/core/rendering/RenderBox.cpp
index 0cd73ebb5023e176261b0efd7611bc6e6cdf7cd7..4c803e874a12a4771ff22c519479e2703c9ad406 100644
--- a/sky/engine/core/rendering/RenderBox.cpp
+++ b/sky/engine/core/rendering/RenderBox.cpp
@@ -128,14 +128,10 @@ void RenderBox::updateFromStyle()
if (isRootObject || isViewObject)
setHasBoxDecorationBackground(true);
- bool boxHasOverflowClip = false;
- if (!styleToUse->isOverflowVisible() && isRenderBlock() && !isViewObject) {
- // If overflow has been propagated to the viewport, it has no effect here.
- if (node() != document().viewportDefiningElement())
- boxHasOverflowClip = true;
- }
+ // TODO(esprehn): Why do we not want to set this on the RenderView?
+ if (isRenderBlock() && !isViewObject)
+ setHasOverflowClip(!styleToUse->isOverflowVisible());
- setHasOverflowClip(boxHasOverflowClip);
setHasTransform(styleToUse->hasTransformRelatedProperty());
}
« no previous file with comments | « sky/engine/core/dom/Document.cpp ('k') | sky/engine/core/rendering/RenderLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698