Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 858713002: Remove viewportDefiningElement. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove viewportDefiningElement. This was used for quirky scrollbar behavior on the web related to which element defined in the viewport (body, html, etc.). In Sky we plan to allow multiple elements as direct children of the Document so we need to get rid of checks like this. The good news is this already does nothing in sky because the root never has scrollbars automatically. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5c9518c84b3641e6a1f804446a360f9835ab1779

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -45 lines) Patch
M sky/engine/core/dom/Document.h View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/dom/Document.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
esprehn
5 years, 11 months ago (2015-01-17 02:31:42 UTC) #1
ojan
lgtm
5 years, 11 months ago (2015-01-17 02:34:41 UTC) #2
esprehn
5 years, 11 months ago (2015-01-17 02:35:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5c9518c84b3641e6a1f804446a360f9835ab1779 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698