Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: src/ast.h

Issue 858673002: Fix issue with __proto__ when using ES6 object literals (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: git rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast.h
diff --git a/src/ast.h b/src/ast.h
index 716fdeda57766b83914d9d1e3d760fae9579c75b..74d6461cec1cdec8a0157f0ab422d233218e036d 100644
--- a/src/ast.h
+++ b/src/ast.h
@@ -1452,12 +1452,10 @@ class ObjectLiteralProperty FINAL : public ZoneObject {
protected:
friend class AstNodeFactory;
- ObjectLiteralProperty(Zone* zone, AstValueFactory* ast_value_factory,
- Expression* key, Expression* value, bool is_static,
- bool is_computed_name);
-
- ObjectLiteralProperty(Zone* zone, bool is_getter, Expression* key,
- FunctionLiteral* value, bool is_static,
+ ObjectLiteralProperty(Expression* key, Expression* value, Kind kind,
+ bool is_static, bool is_computed_name);
+ ObjectLiteralProperty(AstValueFactory* ast_value_factory, Expression* key,
+ Expression* value, bool is_static,
bool is_computed_name);
private:
@@ -3355,20 +3353,18 @@ class AstNodeFactory FINAL BASE_EMBEDDED {
boilerplate_properties, has_function, pos);
}
+ ObjectLiteral::Property* NewObjectLiteralProperty(
+ Expression* key, Expression* value, ObjectLiteralProperty::Kind kind,
+ bool is_static, bool is_computed_name) {
+ return new (zone_)
+ ObjectLiteral::Property(key, value, kind, is_static, is_computed_name);
+ }
+
ObjectLiteral::Property* NewObjectLiteralProperty(Expression* key,
Expression* value,
bool is_static,
bool is_computed_name) {
- return new (zone_) ObjectLiteral::Property(
- zone_, ast_value_factory_, key, value, is_static, is_computed_name);
- }
-
- ObjectLiteral::Property* NewObjectLiteralProperty(bool is_getter,
- Expression* key,
- FunctionLiteral* value,
- int pos, bool is_static,
- bool is_computed_name) {
- return new (zone_) ObjectLiteral::Property(zone_, is_getter, key, value,
+ return new (zone_) ObjectLiteral::Property(ast_value_factory_, key, value,
is_static, is_computed_name);
}
« no previous file with comments | « no previous file | src/ast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698