Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 858673002: Fix issue with __proto__ when using ES6 object literals (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: git rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/preparser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 2451 matching lines...) Expand 10 before | Expand all | Expand 10 after
2462 } else { 2462 } else {
2463 __ push(Operand(esp, 0)); // prototype 2463 __ push(Operand(esp, 0)); // prototype
2464 } 2464 }
2465 EmitPropertyKey(property); 2465 EmitPropertyKey(property);
2466 VisitForStackValue(value); 2466 VisitForStackValue(value);
2467 EmitSetHomeObjectIfNeeded(value, 2); 2467 EmitSetHomeObjectIfNeeded(value, 2);
2468 2468
2469 switch (property->kind()) { 2469 switch (property->kind()) {
2470 case ObjectLiteral::Property::CONSTANT: 2470 case ObjectLiteral::Property::CONSTANT:
2471 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 2471 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
2472 case ObjectLiteral::Property::PROTOTYPE:
2473 UNREACHABLE();
2472 case ObjectLiteral::Property::COMPUTED: 2474 case ObjectLiteral::Property::COMPUTED:
2473 case ObjectLiteral::Property::PROTOTYPE:
2474 __ CallRuntime(Runtime::kDefineClassMethod, 3); 2475 __ CallRuntime(Runtime::kDefineClassMethod, 3);
2475 break; 2476 break;
2476 2477
2477 case ObjectLiteral::Property::GETTER: 2478 case ObjectLiteral::Property::GETTER:
2478 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3); 2479 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked, 3);
2479 break; 2480 break;
2480 2481
2481 case ObjectLiteral::Property::SETTER: 2482 case ObjectLiteral::Property::SETTER:
2482 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3); 2483 __ CallRuntime(Runtime::kDefineSetterPropertyUnchecked, 3);
2483 break; 2484 break;
2484
2485 default:
2486 UNREACHABLE();
2487 } 2485 }
2488 } 2486 }
2489 2487
2490 // prototype 2488 // prototype
2491 __ CallRuntime(Runtime::kToFastProperties, 1); 2489 __ CallRuntime(Runtime::kToFastProperties, 1);
2492 2490
2493 // constructor 2491 // constructor
2494 __ CallRuntime(Runtime::kToFastProperties, 1); 2492 __ CallRuntime(Runtime::kToFastProperties, 1);
2495 } 2493 }
2496 2494
(...skipping 2739 matching lines...) Expand 10 before | Expand all | Expand 10 after
5236 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 5234 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
5237 Assembler::target_address_at(call_target_address, 5235 Assembler::target_address_at(call_target_address,
5238 unoptimized_code)); 5236 unoptimized_code));
5239 return OSR_AFTER_STACK_CHECK; 5237 return OSR_AFTER_STACK_CHECK;
5240 } 5238 }
5241 5239
5242 5240
5243 } } // namespace v8::internal 5241 } } // namespace v8::internal
5244 5242
5245 #endif // V8_TARGET_ARCH_IA32 5243 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/preparser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698