Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 858663002: Fix template angle bracket syntax in platform (Closed)

Created:
5 years, 11 months ago by rwlbuis
Modified:
5 years, 11 months ago
Reviewers:
adamk
CC:
blink-reviews, shans, eae+blinkwatch, leviw+bidiwatch_chromium.org, Steve Block, krit, blink-reviews-events_chromium.org, dglazkov+blink, danakj, dstockwell, Timothy Loh, Rik, Eric Willigers, rjwright, Mads Ager (chromium), jbroman, Raymond Toy, Dominik Röttsches, tommyw+watchlist_chromium.org, pdr+graphicswatchlist_chromium.org, darktears, haraken, blink-reviews-animation_chromium.org, blink-layers+watch_chromium.org, Mike Lawther (Google), f(malita), oilpan-reviews, Stephen Chennney, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix template angle bracket syntax in platform In C++11 the parser is able to parse >> as the end of the template argument list. BUG=449681 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188567

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -306 lines) Patch
M Source/platform/AsyncMethodRunner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/CheckedInt.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/CrossThreadCopier.h View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/JSONValues.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/JSONValues.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/Length.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PODArena.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PODFreeListArena.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/PODFreeListArenaTest.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/PODIntervalTree.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/PODIntervalTreeTest.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/PODRedBlackTree.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/Supplementable.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/TraceEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/TracedValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/animation/KeyframeValueList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/animation/TimingFunctionTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/platform/audio/AudioBus.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioDSPKernelProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/AudioResampler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/DynamicsCompressorKernel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/HRTFDatabase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/HRTFDatabaseLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/HRTFElevation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/HRTFKernel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/MultiChannelResampler.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/Reverb.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/audio/ReverbConvolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/blob/BlobRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebMediaStreamSource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/linux/WebFontInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontCache.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/fonts/FontDataCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/FontDataCache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/GlyphMetricsMap.h View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/platform/fonts/GlyphPageTreeNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/SimpleFontData.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/WidthCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/shaping/HarfBuzzFace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/skia/FontCacheSkia.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/win/FontCacheSkiaWin.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/geometry/FloatPolygon.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/geometry/FloatPolygon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/geometry/FloatPolygonTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/DeferredImageDecoder.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/GraphicsContextAnnotation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ImageDecodingStore.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/graphics/ImageDecodingStore.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/platform/graphics/ThreadSafeDataTransport.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/ThreadSafeDataTransport.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/FilterEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FilterOperations.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/Handle.h View 6 chunks +20 lines, -20 lines 0 comments Download
M Source/platform/heap/Heap.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/heap/HeapLinkedStack.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/heap/HeapTerminatedArray.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/HeapTest.cpp View 44 chunks +102 lines, -102 lines 0 comments Download
M Source/platform/heap/Visitor.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/image-decoders/gif/GIFImageReader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/image-decoders/ico/ICOImageDecoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/mediastream/MediaStreamComponent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mediastream/MediaStreamDescriptor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/mediastream/MediaStreamSource.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/mediastream/MediaStreamSource.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/mediastream/RTCConfiguration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/mhtml/ArchiveResourceCollection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/mhtml/MHTMLArchive.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/mhtml/MHTMLParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/network/HTTPHeaderMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/HTTPParsers.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeMacOverlayAPI.mm View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/speech/PlatformSpeechSynthesizer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/speech/PlatformSpeechSynthesizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/BidiResolver.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/text/LocaleICU.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/text/LocaleICU.cpp View 7 chunks +16 lines, -16 lines 0 comments Download
M Source/platform/transforms/TransformOperations.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/weborigin/SecurityOriginHash.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/weborigin/SecurityPolicy.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
rwlbuis
PTAL
5 years, 11 months ago (2015-01-16 22:28:45 UTC) #2
adamk
This seems fine, but I'm curious what the broader plan is. Does this patch include ...
5 years, 11 months ago (2015-01-16 22:34:32 UTC) #3
rwlbuis
On 2015/01/16 22:34:32, adamk wrote: > This seems fine, but I'm curious what the broader ...
5 years, 11 months ago (2015-01-16 22:38:59 UTC) #4
rwlbuis
On 2015/01/16 22:38:59, rwlbuis wrote: > On 2015/01/16 22:34:32, adamk wrote: > > This seems ...
5 years, 11 months ago (2015-01-16 22:39:31 UTC) #5
rwlbuis
On 2015/01/16 22:38:59, rwlbuis wrote: > On 2015/01/16 22:34:32, adamk wrote: > > This seems ...
5 years, 11 months ago (2015-01-16 22:39:33 UTC) #6
adamk
On 2015/01/16 22:39:33, rwlbuis wrote: > On 2015/01/16 22:38:59, rwlbuis wrote: > > On 2015/01/16 ...
5 years, 11 months ago (2015-01-16 22:53:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858663002/1
5 years, 11 months ago (2015-01-16 23:00:04 UTC) #9
commit-bot: I haz the power
Failed to apply patch for Source/platform/graphics/GraphicsContextRecorder.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
5 years, 11 months ago (2015-01-16 23:00:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858663002/20001
5 years, 11 months ago (2015-01-16 23:28:30 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-17 00:49:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188567

Powered by Google App Engine
This is Rietveld 408576698