Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 858643002: webkit: Cleanup - make everything private as much as possible. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 11 months ago
Reviewers:
piman
CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, darin (slow to review), Avi (use Gerrit), jochen (gone - plz use gerrit), pilgrim_google, jam, jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webkit: Cleanup - make everything private as much as possible. This helps to reduce the public surface of this API and makes clear what can be accessed by the clients/consumers of this API. BUG=338338 TEST=None R=piman@chromium.org Committed: https://crrev.com/9c951cf71dcd32f75ccd0c68bd342a2eb434d700 Cr-Commit-Position: refs/heads/master@{#311976}

Patch Set 1 #

Patch Set 2 : header changes #

Patch Set 3 : another fix #

Patch Set 4 : IWYU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M ui/compositor/test/in_process_context_factory.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.h View 1 2 3 4 chunks +17 lines, -12 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
PTAL
5 years, 11 months ago (2015-01-16 20:08:18 UTC) #1
piman
lgtm
5 years, 11 months ago (2015-01-16 21:38:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858643002/60001
5 years, 11 months ago (2015-01-16 22:30:46 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-16 23:27:25 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 23:28:13 UTC) #6
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9c951cf71dcd32f75ccd0c68bd342a2eb434d700
Cr-Commit-Position: refs/heads/master@{#311976}

Powered by Google App Engine
This is Rietveld 408576698