Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2833)

Unified Diff: chrome/browser/policy/cloud_policy_provider_impl.cc

Issue 8586030: Added ConfigurationPolicyProvider::RefreshPolicies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/cloud_policy_provider_impl.cc
diff --git a/chrome/browser/policy/cloud_policy_provider_impl.cc b/chrome/browser/policy/cloud_policy_provider_impl.cc
index d1c3f3b7a21b50289370dc6f0524bcc5caeb9c40..ee09b78b6b3a7b3a3e2765660d1610f31970502e 100644
--- a/chrome/browser/policy/cloud_policy_provider_impl.cc
+++ b/chrome/browser/policy/cloud_policy_provider_impl.cc
@@ -4,14 +4,19 @@
#include "chrome/browser/policy/cloud_policy_provider_impl.h"
+#include <algorithm>
+
+#include "chrome/browser/policy/browser_policy_connector.h"
#include "chrome/browser/policy/configuration_policy_pref_store.h"
namespace policy {
CloudPolicyProviderImpl::CloudPolicyProviderImpl(
+ BrowserPolicyConnector* browser_policy_connector,
const PolicyDefinitionList* policy_list,
CloudPolicyCacheBase::PolicyLevel level)
: CloudPolicyProvider(policy_list),
+ browser_policy_connector_(browser_policy_connector),
level_(level),
initialization_complete_(true) {}
@@ -29,19 +34,23 @@ bool CloudPolicyProviderImpl::IsInitializationComplete() const {
return initialization_complete_;
}
+void CloudPolicyProviderImpl::RefreshPolicies() {
+ pending_update_caches_ = caches_;
+ if (pending_update_caches_.empty())
+ NotifyPolicyUpdated();
+ else
+ browser_policy_connector_->FetchCloudPolicy();
+}
+
void CloudPolicyProviderImpl::OnCacheUpdate(CloudPolicyCacheBase* cache) {
+ RemoveCache(cache, &pending_update_caches_);
RecombineCachesAndTriggerUpdate();
}
void CloudPolicyProviderImpl::OnCacheGoingAway(CloudPolicyCacheBase* cache) {
cache->RemoveObserver(this);
- for (ListType::iterator i = caches_.begin(); i != caches_.end(); ++i) {
- if (*i == cache) {
- caches_.erase(i);
- break;
- }
- }
-
+ RemoveCache(cache, &caches_);
+ RemoveCache(cache, &pending_update_caches_);
RecombineCachesAndTriggerUpdate();
}
@@ -112,7 +121,16 @@ void CloudPolicyProviderImpl::RecombineCachesAndTriggerUpdate() {
// Trigger a notification.
combined_.Swap(&newly_combined);
- NotifyPolicyUpdated();
+ if (pending_update_caches_.empty())
+ NotifyPolicyUpdated();
+}
+
+// static
+void CloudPolicyProviderImpl::RemoveCache(CloudPolicyCacheBase* cache,
+ ListType* caches) {
+ ListType::iterator it = std::find(caches->begin(), caches->end(), cache);
+ if (it != caches->end())
+ caches->erase(it);
}
} // namespace policy
« no previous file with comments | « chrome/browser/policy/cloud_policy_provider_impl.h ('k') | chrome/browser/policy/cloud_policy_provider_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698