Issue 858453002: Require a type for SkyElement attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 858453002: Require a type for SkyElement attributes. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Require a type for SkyElement attributes. Instead of defaulting to string require a specific type. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d7e788fc727384b3d52b5853b89eba6b19a20329

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
	M	sky/framework/sky-element/sky-element.sky	View	1	1 chunk	+21 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

esprehn

5 years, 11 months ago (2015-01-16 01:34:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d7e788fc727384b3d52b5853b89eba6b19a20329 (presubmit successful).