Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 858453002: Require a type for SkyElement attributes. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Require a type for SkyElement attributes. Instead of defaulting to string require a specific type. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d7e788fc727384b3d52b5853b89eba6b19a20329

Patch Set 1 #

Patch Set 2 : Handle null attr. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M sky/framework/sky-element/sky-element.sky View 1 1 chunk +21 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
esprehn
5 years, 11 months ago (2015-01-16 01:19:04 UTC) #1
esprehn
5 years, 11 months ago (2015-01-16 01:24:26 UTC) #2
ojan
lgtm
5 years, 11 months ago (2015-01-16 01:29:30 UTC) #3
esprehn
5 years, 11 months ago (2015-01-16 01:34:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d7e788fc727384b3d52b5853b89eba6b19a20329 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698