Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: sky/engine/core/css/resolver/ScopedStyleResolver.h

Issue 858423002: Don't store a RuleFeatureSet on ScopedStyleResolver. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: better test names. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/css/StyleSheetContents.h ('k') | sky/engine/core/css/resolver/ScopedStyleResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/resolver/ScopedStyleResolver.h
diff --git a/sky/engine/core/css/resolver/ScopedStyleResolver.h b/sky/engine/core/css/resolver/ScopedStyleResolver.h
index 4ba3a2738542fc4e0e4d7e65c0a3626d9407cf10..e18cd7f0004988fc2e4c6e0211cb25a48c13b1e3 100644
--- a/sky/engine/core/css/resolver/ScopedStyleResolver.h
+++ b/sky/engine/core/css/resolver/ScopedStyleResolver.h
@@ -42,7 +42,6 @@ namespace blink {
class CSSStyleSheet;
class ContainerNode;
class HTMLStyleElement;
-class RuleFeatureSet;
class StyleSheetContents;
// This class selects a RenderStyle for a given element based on a collection of stylesheets.
@@ -62,11 +61,12 @@ public:
void collectMatchingAuthorRules(ElementRuleCollector&, CascadeOrder = ignoreCascadeOrder);
void collectMatchingHostRules(ElementRuleCollector&, CascadeOrder = ignoreCascadeOrder);
- const RuleFeatureSet& features() const { return m_features; }
+ bool hasSelectorForId(const AtomicString& id) const;
+ bool hasSelectorForClass(const AtomicString& className) const;
+ bool hasSelectorForAttribute(const AtomicString& attributeName) const;
void updateActiveStyleSheets();
- Vector<RefPtr<CSSStyleSheet>>& authorStyleSheets() { return m_authorStyleSheets; }
const Vector<RefPtr<CSSStyleSheet>>& authorStyleSheets() const { return m_authorStyleSheets; }
void addStyleSheetCandidateNode(HTMLStyleElement&);
@@ -75,13 +75,11 @@ public:
private:
explicit ScopedStyleResolver(TreeScope&);
- void appendStyleSheet(CSSStyleSheet&);
void collectStyleSheets(Vector<RefPtr<CSSStyleSheet>>& candidateSheets);
TreeScope& m_scope;
DocumentOrderedList m_styleSheetCandidateNodes;
Vector<RefPtr<CSSStyleSheet>> m_authorStyleSheets;
- RuleFeatureSet m_features;
};
} // namespace blink
« no previous file with comments | « sky/engine/core/css/StyleSheetContents.h ('k') | sky/engine/core/css/resolver/ScopedStyleResolver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698