Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 858423002: Don't store a RuleFeatureSet on ScopedStyleResolver. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan, abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't store a RuleFeatureSet on ScopedStyleResolver. Instead lets just iterate the list of sheets and ask each one questions. This shouldn't be much slower since most widgets only have one sheet anyway. I also moved the media query matching to the sheet collection. We weren't correctly matching them since we only guarded the feature set, not the addition to the list of active sheets. R=abarth@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d87602b17cc45a679ecfb9740787418ecc9b83c3

Patch Set 1 #

Patch Set 2 : add a test. #

Patch Set 3 : better test names. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -31 lines) Patch
M sky/engine/core/css/StyleSheetContents.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.h View 3 chunks +3 lines, -5 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.cpp View 6 chunks +36 lines, -18 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
A sky/tests/styles/media-queries.sky View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A sky/tests/styles/media-queries-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-22 00:57:03 UTC) #2
esprehn
5 years, 11 months ago (2015-01-22 01:00:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d87602b17cc45a679ecfb9740787418ecc9b83c3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698