Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 858363005: Oilpan: expose near-finalized predicate as Heap::willObjectBeLazilySwept() (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: expose near-finalized predicate as Heap::willObjectBeLazilySwept() Provide an inverted, and more focused version of the previous isFinalizedObjectAlive() predicate. willObjectBeLazilySwept() returns true iff an object reference has been slated for finalization by sweeping, but hasn't been yet. R=haraken BUG=448392 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188804

Patch Set 1 #

Total comments: 2

Patch Set 2 : assert for valid object reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M Source/platform/Timer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/Heap.h View 1 1 chunk +15 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
Please take a look.
5 years, 11 months ago (2015-01-22 09:19:58 UTC) #2
haraken
LGTM https://codereview.chromium.org/858363005/diff/1/Source/platform/heap/Heap.h File Source/platform/heap/Heap.h (right): https://codereview.chromium.org/858363005/diff/1/Source/platform/heap/Heap.h#newcode861 Source/platform/heap/Heap.h:861: // to be in; willObjectBeLazilySwept() has undefined behavior ...
5 years, 11 months ago (2015-01-22 09:29:30 UTC) #4
sof
https://codereview.chromium.org/858363005/diff/1/Source/platform/heap/Heap.h File Source/platform/heap/Heap.h (right): https://codereview.chromium.org/858363005/diff/1/Source/platform/heap/Heap.h#newcode861 Source/platform/heap/Heap.h:861: // to be in; willObjectBeLazilySwept() has undefined behavior if ...
5 years, 11 months ago (2015-01-22 09:56:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858363005/20001
5 years, 11 months ago (2015-01-22 10:45:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=188804
5 years, 11 months ago (2015-01-22 11:41:25 UTC) #8
sof
5 years, 11 months ago (2015-01-22 13:21:25 UTC) #9
Message was sent while issue was closed.
On 2015/01/22 09:56:23, sof wrote:
> https://codereview.chromium.org/858363005/diff/1/Source/platform/heap/Heap.h
> File Source/platform/heap/Heap.h (right):
> 
>
https://codereview.chromium.org/858363005/diff/1/Source/platform/heap/Heap.h#...
> Source/platform/heap/Heap.h:861: // to be in; willObjectBeLazilySwept() has
> undefined behavior if passed
> On 2015/01/22 09:29:29, haraken wrote:
> > 
> > Can we assert this by checking header->checkHeader()?
> 
> That would be helpful, added.

That won't work out readily for mixins. As isMarked() already checks for this, I
will remove.

Powered by Google App Engine
This is Rietveld 408576698