Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 858363003: ICU update to 54.1 - step 5 (Closed)

Created:
5 years, 11 months ago by jungshik at Google
Modified:
5 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

ICU update to 54.1 - step 5 1. Apply Chrome's locale data change on top of Google's locale data changes 2. Breakiterator changes - Apply brkitr.patch with update to ICU 54.1; line/word.txt - Check in a more compact Khmer dictionary along with a parameter adjustment in dictbe.cpp - Add a few common words to the CJ dictionary - Update brklocal.mk (out customized build file) to ICU 54 - Update android/brkitr.patch and data/brkitr/word_ja.txt for Android Data size checkpoint: * Non-Android: 19,575,216 bytes. ~500kB reduction relative to the previous step comes mainly from the compact Khmer dictionary. * Android: 17,601,520 bytes. 2MB difference comes from removing cjdict. BUG=428145 TEST=net_unittests --gtest_filter="*IDN*" TEST=layout tests R=mark@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/icu/+/4a0ebf1135eb3f2ac241790c41d3c2e7b2c7c689

Patch Set 1 #

Patch Set 2 : brkitr changes #

Patch Set 3 : drop 'ja' from BRK_FILES in brklocal.mk #

Patch Set 4 : android brkitr update #

Patch Set 5 : ja exemplar charset fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+927 lines, -690 lines) Patch
M README.chromium View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
M android/brkitr.patch View 1 2 3 4 5 chunks +34 lines, -35 lines 0 comments Download
M patches/brkitr.patch View 1 2 3 4 4 chunks +11 lines, -10 lines 0 comments Download
A patches/cjdict.patch View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
M patches/khmer-dictbe.patch View 1 2 3 4 1 chunk +11 lines, -11 lines 0 comments Download
M patches/locale1.patch View 1 2 3 4 8 chunks +292 lines, -391 lines 0 comments Download
M source/common/dictbe.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + source/data/brkitr/brklocal.mk View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M source/data/brkitr/cjdict.txt View 4 chunks +7 lines, -0 lines 0 comments Download
M source/data/brkitr/line.txt View 1 2 3 4 3 chunks +8 lines, -9 lines 0 comments Download
M source/data/brkitr/word.txt View 1 2 3 4 1 chunk +9 lines, -3 lines 0 comments Download
A + source/data/brkitr/word_ja.txt View 1 2 3 4 9 chunks +19 lines, -19 lines 0 comments Download
M source/data/lang/ko.txt View 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M source/data/locales/bn.txt View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M source/data/locales/gu.txt View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M source/data/locales/hi.txt View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M source/data/locales/ja.txt View 1 2 3 4 1 chunk +204 lines, -54 lines 0 comments Download
M source/data/locales/kn.txt View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M source/data/locales/ko.txt View 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M source/data/locales/mr.txt View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M source/data/locales/ta.txt View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M source/data/locales/te.txt View 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M source/data/locales/tr.txt View 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M source/data/locales/zh.txt View 2 3 4 1 chunk +1 line, -55 lines 0 comments Download
M source/data/locales/zh_Hant.txt View 2 3 4 1 chunk +234 lines, -56 lines 0 comments Download
M source/data/zone/ko.txt View 2 3 4 3 chunks +32 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jungshik at Google
Mark, sorry for bothering you again. There are a few more steps. (the 2nd half ...
5 years, 11 months ago (2015-01-23 00:48:14 UTC) #2
Mark Mentovai
No worries. LGTM.
5 years, 11 months ago (2015-01-23 04:46:59 UTC) #3
jungshik at Google
5 years, 11 months ago (2015-01-23 23:03:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 (id:50001) manually as
4a0ebf1135eb3f2ac241790c41d3c2e7b2c7c689 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698