Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: chrome/test/chromedriver/chrome_launcher.cc

Issue 858353002: [chromedriver] Fixed window SendKeys (single quote missing) problem (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove one debug print statement Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome_launcher.cc
diff --git a/chrome/test/chromedriver/chrome_launcher.cc b/chrome/test/chromedriver/chrome_launcher.cc
index 03a5e1f6593010b06c143a4dc736727c7f71f6a9..cc66330811bd65b1cb96b3745dbce43177d2f3cc 100644
--- a/chrome/test/chromedriver/chrome_launcher.cc
+++ b/chrome/test/chromedriver/chrome_launcher.cc
@@ -53,6 +53,7 @@
#include <sys/types.h>
#elif defined(OS_WIN)
#include "base/win/scoped_handle.h"
+#include "chrome/test/chromedriver/keycode_text_conversion.h"
#endif
namespace {
@@ -344,6 +345,10 @@ Status LaunchDesktopChrome(
options.stderr_handle = out_write;
options.stdin_handle = GetStdHandle(STD_INPUT_HANDLE);
options.inherit_handles = true;
+ // use US keyboard layout for key conversion
+ if (!SwitchToUSKeyboardLayout()) {
+ VLOG(0) << "Can not set to US keyboard layout\n";
samuong 2015/01/23 19:36:58 We should also mention that some keycodes may be i
andrewcheng1 2015/01/24 01:40:00 Done.
andrewcheng1 2015/02/19 00:56:59 Done.
+ }
samuong 2015/01/23 19:36:58 You mentioned earlier that this is a per-process s
andrewcheng1 2015/01/24 01:40:00 sent you email - main() will not work (reason n
andrewcheng1 2015/02/19 00:56:59 sent you email - main() will not work (which it
#endif
#if defined(OS_WIN)

Powered by Google App Engine
This is Rietveld 408576698