[chromedriver] Fixed window SendKeys (single quote missing) problem

chrome/test/chromedriver/keycode_text_conversion_win.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/keycode_text_conversion.h"
 
+#include <VersionHelpers.h>
 #include <stdlib.h>
 #include <windows.h>
 
+#include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/chromedriver/chrome/ui_events.h"
 
+#define US_KEYBOARD_LAYOUT L"00000409"

[samuong, 2015/02/18 19:59:34]

We should use const variables instead of #defines, so something like:

LPCTSTR kUsKeyboardLayout = TEXT("00000409");

+
 bool ConvertKeyCodeToText(
     ui::KeyboardCode key_code, int modifiers, std::string* text,
     std::string* error_msg) {
   UINT scan_code = ::MapVirtualKeyW(key_code, MAPVK_VK_TO_VSC);
   BYTE keyboard_state[256];
   memset(keyboard_state, 0, 256);
   *error_msg = std::string();
   if (modifiers & kShiftKeyModifierMask)
     keyboard_state[VK_SHIFT] |= 0x80;
   if (modifiers & kControlKeyModifierMask)
@@ skipping 27 matching lines @@
       modifiers |= kShiftKeyModifierMask;
     if (win_modifiers & 0x02)
       modifiers |= kControlKeyModifierMask;
     if (win_modifiers & 0x04)
       modifiers |= kAltKeyModifierMask;
     // Ignore bit 0x08: It is for Hankaku key.
     *necessary_modifiers = modifiers;
   }
   return translated;
 }
+
+bool SwitchToUSKeyboardLayout() {
+

[samuong, 2015/02/18 19:59:35]

nit: delete blank line

+  // For LoadKeyboardLayout - Prior to Windows 8: If the specified input
+  // locale identifier is not already loaded, the function loads and
+  // activates the input locale identifier for the current thread.
+  // Beginning in Windows 8: If the specified input locale identifier is not
+  // already loaded, the function loads and activates the input
+  // locale identifier for the system.
+  // For Windows 8 - Use ActivateKeyboardLayout instead of LoadKeyboardLayout
+  if (IsWindows8OrGreater()) {
+    int size;
+    TCHAR active_keyboard[KL_NAMELENGTH];
+
+    if ((size = ::GetKeyboardLayoutList(0, NULL)) <= 0)
+      return false;
+
+    scoped_ptr<HKL[]> keyboard_handles_list(new HKL[size]);
+    ::GetKeyboardLayoutList(size, keyboard_handles_list.get());
+
+    for (int keyboard_index = 0; keyboard_index < size; keyboard_index++) {
+      ::ActivateKeyboardLayout(keyboard_handles_list[keyboard_index],
+          KLF_SETFORPROCESS);
+      ::GetKeyboardLayoutName(active_keyboard);
+      // if active keyboard match US keyboard layout - 00000409

[samuong, 2015/02/18 19:59:34]

delete this comment

+      if (wcscmp(active_keyboard, US_KEYBOARD_LAYOUT) == 0)
+        return true;
+    }
+    return false;
+  } else {
+    HKL layout = ::LoadKeyboardLayout((LPCTSTR)US_KEYBOARD_LAYOUT,
+                                       KLF_ACTIVATE);
+    if (!layout)
+      return false;
+    else
+      return true;

[samuong, 2015/02/18 19:59:35]

return ::LoadKeyboardLayout(kUsKeyboardLayout, KLF_ACTIVATE) != NULL;

+  }
+}