ui/events/ozone/evdev/keyboard_evdev.cc - Issue 858333006: [PATCH 9.6/11] ozone: evdev: Remove extra PostTask during dispatch from EventFactoryEvdev

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/evdev/keyboard_evdev.cc

Issue 858333006: [PATCH 9.6/11] ozone: evdev: Remove extra PostTask during dispatch from EventFactoryEvdev (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/events/ozone/evdev/event_factory_evdev.cc ('K') | « ui/events/ozone/evdev/input_injector_evdev_unittest.cc ('k') | ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/ozone/evdev/keyboard_evdev.cc

diff --git a/ui/events/ozone/evdev/keyboard_evdev.cc b/ui/events/ozone/evdev/keyboard_evdev.cc

index 5ba1ed91bc996ef7e520cf7b22e62148d969e12d..a1d6f41d82458ec9ae01dbcd81387971939ae827 100644

--- a/ui/events/ozone/evdev/keyboard_evdev.cc

+++ b/ui/events/ozone/evdev/keyboard_evdev.cc

@@ -172,12 +172,11 @@ void KeyboardEvdev::DispatchKey(unsigned int key, bool down, bool repeat) {

if (!repeat)

UpdateModifier(ModifierDomKeyToEventFlag(dom_key), down);

- KeyEvent* event =

- new KeyEvent(down ? ET_KEY_PRESSED : ET_KEY_RELEASED, key_code, dom_code,

- modifiers_->GetModifierFlags(), dom_key, character);

+ KeyEvent event(down ? ET_KEY_PRESSED : ET_KEY_RELEASED, key_code, dom_code,

+ modifiers_->GetModifierFlags(), dom_key, character);

if (platform_keycode)

- event->set_platform_keycode(platform_keycode);

- callback_.Run(make_scoped_ptr(event));

+ event.set_platform_keycode(platform_keycode);

+ callback_.Run(&event);

}

} // namespace ui