Muck with the right cinfo.

Muck with the right cinfo.

In SkImageDecoder_libjpeg, modify cinfo *after* destroying it and
creating a new one in its place.

Should fix build breakage.

Committed: https://skia.googlesource.com/skia/+/3629865bac20ae8092177f519594f79f89d09fb0

Committed: https://skia.googlesource.com/skia/+/6d7e47a8e0c8fd80ad33f659b01ec84f9e93a94b

[scroggo, 2015-01-21 21:25:26]

scroggo@google.com changed reviewers:
+ bungeman@gmail.com

[scroggo, 2015-01-21 21:26:51]

On 2015/01/21 21:25:26, scroggo wrote:

Running a try to make sure it fixes the error seen here:

http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...

[scroggo, 2015-01-21 21:34:22]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2015-01-21 21:34:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/858333002/20001

[commit-bot: I haz the power, 2015-01-21 21:34:36]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-01-22 03:34 UTC

[bungeman-skia, 2015-01-21 22:02:10]

bungeman@google.com changed reviewers:
+ bungeman@google.com
- bungeman@gmail.com

[bungeman-skia, 2015-01-21 22:03:22]

lgtm

[commit-bot: I haz the power, 2015-01-21 22:05:00]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3629865bac20ae8092177f519594f79f89d09fb0

[mtklein, 2015-01-21 23:03:27]

On 2015/01/21 22:05:00, I haz the power (commit-bot) wrote:
> Committed patchset #2 (id:20001) as
> https://skia.googlesource.com/skia/+/3629865bac20ae8092177f519594f79f89d09fb0

This CL may need some work?  Looks like DM's segfaulting on most but not all
Android bots.

[bungeman-skia, 2015-01-21 23:07:14]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/858323003/ by bungeman@google.com.

The reason for reverting is: Appears to cause Android dm to segfault..

[scroggo, 2015-01-22 15:36:32]

scroggo@google.com changed reviewers:
+ mtklein@google.com

[scroggo, 2015-01-22 15:36:32]

I was able to reproduce the DM segfault on my razor, and ps 3 fixes that. PTAL

[bungeman-skia, 2015-01-22 17:14:49]

On 2015/01/22 15:36:32, scroggo wrote:
> I was able to reproduce the DM segfault on my razor, and ps 3 fixes that. PTAL

From the Xoom log, of the successful dm run on PS3:
> libjpeg error 66 <Write failed on temporary file --- out of disk space?> from
setjmp [0 0]
> Skia Error: Parse Error: Could not decode bitmap. Resulting bitmap will be
empty.

lgtm

[bungeman-skia, 2015-01-22 18:19:24]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-01-22 18:20:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/858333002/40001

[commit-bot: I haz the power, 2015-01-22 18:27:29]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6d7e47a8e0c8fd80ad33f659b01ec84f9e93a94b

[scroggo, 2015-01-22 18:27:52]

On 2015/01/22 17:14:49, bungeman1 wrote:
> On 2015/01/22 15:36:32, scroggo wrote:
> > I was able to reproduce the DM segfault on my razor, and ps 3 fixes that.
PTAL
> 
> From the Xoom log, of the successful dm run on PS3:
> > libjpeg error 66 <Write failed on temporary file --- out of disk space?>
from
> setjmp [0 0]
> > Skia Error: Parse Error: Could not decode bitmap. Resulting bitmap will be
> empty.

I think that is skbug.com/1282
> 
> lgtm