Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 858323003: Revert of Muck with the right cinfo. (Closed)

Created:
5 years, 11 months ago by bungeman-skia
Modified:
5 years, 11 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@anotherFix
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Muck with the right cinfo. (patchset #2 id:20001 of https://codereview.chromium.org/858333002/) Reason for revert: Appears to cause Android dm to segfault. Original issue's description: > Muck with the right cinfo. > > In SkImageDecoder_libjpeg, modify cinfo *after* destroying it and > creating a new one in its place. > > Should fix build breakage. > > Committed: https://skia.googlesource.com/skia/+/3629865bac20ae8092177f519594f79f89d09fb0 TBR=scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/aa7079b4a19e6d53040c4fb5cd62f2dd39c2595e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/images/SkImageDecoder_libjpeg.cpp View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bungeman-skia
Created Revert of Muck with the right cinfo.
5 years, 11 months ago (2015-01-21 23:07:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858323003/1
5 years, 11 months ago (2015-01-21 23:08:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/aa7079b4a19e6d53040c4fb5cd62f2dd39c2595e
5 years, 11 months ago (2015-01-21 23:08:13 UTC) #3
bungeman-skia
On 2015/01/21 23:08:13, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
5 years, 11 months ago (2015-01-21 23:11:27 UTC) #4
bungeman-skia
5 years, 11 months ago (2015-01-22 00:03:59 UTC) #5
Message was sent while issue was closed.
On 2015/01/21 23:11:27, bungeman1 wrote:
> On 2015/01/21 23:08:13, I haz the power (commit-bot) wrote:
> > Committed patchset #1 (id:1) as
> >
https://skia.googlesource.com/skia/+/aa7079b4a19e6d53040c4fb5cd62f2dd39c2595e
> 
> The Nexus 7 and 10 seemed ok (ran dm without issue), but S4, Nexus 5 and 9,
and
> Xoom all segfaulted.

Interestingly, the S4 was previously segfaulting, and neither the original
change nor this revert seems to have really affected it. This revert did restore
dm to non-segfaulting on Nexus 5, 9, Player, and Xoom.

Powered by Google App Engine
This is Rietveld 408576698