Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 858323002: QUIC - Deleted disable_loading_server_info_for_new_servers field trial. (Closed)

Created:
5 years, 11 months ago by ramant (doing other things)
Modified:
5 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Deleted disable_loading_server_info_for_new_servers field trial. Changed the code not to load server config if there is no alternative protocol entry for QUIC. During our experiments, we found that disable_loading_server_info_for_new_servers being set to true has reduced the latency until crypto handshake completion. This is a revert of https://codereview.chromium.org/811073004/ We check for alternative protocols only if there is a http_server_properties_ object. R=rch@chromium.org Committed: https://crrev.com/6a454624b8f2827af3ec154bb96e61e7fdcf9e3a Cr-Commit-Position: refs/heads/master@{#312741} Committed: https://crrev.com/c7fe0a44d9af66aa3072df1460f6c85491f21e41 Cr-Commit-Position: refs/heads/master@{#312904}

Patch Set 1 : #

Patch Set 2 : rebase with TOT #

Patch Set 3 : rebase with TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -42 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/io_thread.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/quic_stream_factory.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 3 chunks +1 line, -4 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 30 (12 generated)
ramant (doing other things)
5 years, 11 months ago (2015-01-21 21:14:04 UTC) #1
ramant (doing other things)
Hi Ryan, We have been running with flag enabled in M41-Dev (via field trial). As ...
5 years, 11 months ago (2015-01-22 19:05:00 UTC) #6
Ryan Hamilton
lgtm
5 years, 11 months ago (2015-01-22 19:22:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858323002/20001
5 years, 11 months ago (2015-01-22 19:24:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/17202)
5 years, 11 months ago (2015-01-22 20:10:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858323002/40001
5 years, 11 months ago (2015-01-22 20:30:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/26013)
5 years, 11 months ago (2015-01-22 23:51:29 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858323002/40001
5 years, 11 months ago (2015-01-23 00:28:36 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/26013)
5 years, 11 months ago (2015-01-23 00:30:16 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858323002/40001
5 years, 11 months ago (2015-01-23 01:15:00 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 11 months ago (2015-01-23 01:54:25 UTC) #22
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6a454624b8f2827af3ec154bb96e61e7fdcf9e3a Cr-Commit-Position: refs/heads/master@{#312741}
5 years, 11 months ago (2015-01-23 01:55:38 UTC) #23
benwells
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/871833002/ by benwells@chromium.org. ...
5 years, 11 months ago (2015-01-23 03:04:50 UTC) #24
ramant (doing other things)
On 2015/01/23 03:04:50, benwells wrote: > A revert of this CL (patchset #2 id:40001) has ...
5 years, 11 months ago (2015-01-23 17:42:05 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858323002/60001
5 years, 11 months ago (2015-01-23 19:46:59 UTC) #27
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 11 months ago (2015-01-23 19:51:17 UTC) #28
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c7fe0a44d9af66aa3072df1460f6c85491f21e41 Cr-Commit-Position: refs/heads/master@{#312904}
5 years, 11 months ago (2015-01-23 19:52:20 UTC) #29
ramant (doing other things)
5 years, 11 months ago (2015-01-23 20:09:52 UTC) #30
Message was sent while issue was closed.
On 2015/01/23 19:52:20, I haz the power (commit-bot) wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/c7fe0a44d9af66aa3072df1460f6c85491f21e41
> Cr-Commit-Position: refs/heads/master@{#312904}

It compiled without issues today. Not sure why it failed before.

http://build.chromium.org/p/chromium.mac/builders/iOS%20Device/builds/21551

Powered by Google App Engine
This is Rietveld 408576698