Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 858303004: Exposes cursor position to IME extension through chrome.inputMethodPrivate.onCompositionBoundsChang… (Closed)

Created:
5 years, 11 months ago by Shu Chen
Modified:
5 years, 11 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exposes cursor position to IME extension through chrome.inputMethodPrivate.onCompositionBoundsChanged. BUG=450503 TEST=Verified on linux_chromeos. Committed: https://crrev.com/023242b5702bc0ee849a0cf4c41d3798fdecce2e Cr-Commit-Position: refs/heads/master@{#312558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -15 lines) Patch
M chrome/common/extensions/api/input_method_private.json View 1 chunk +11 lines, -8 lines 0 comments Download
M ui/base/ime/input_method_chromeos.cc View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Shu Chen
Nona, can you please review this cl? Thanks
5 years, 11 months ago (2015-01-22 02:04:37 UTC) #2
Seigo Nonaka
lgtm
5 years, 11 months ago (2015-01-22 02:06:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858303004/1
5 years, 11 months ago (2015-01-22 02:24:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-22 03:53:28 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 03:54:28 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/023242b5702bc0ee849a0cf4c41d3798fdecce2e
Cr-Commit-Position: refs/heads/master@{#312558}

Powered by Google App Engine
This is Rietveld 408576698