Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(798)

Issue 858303002: Reject vp8 video having alpha and image planes of different sizes. (Closed)

Created:
5 years, 8 months ago by watk
Modified:
5 years, 8 months ago
Reviewers:
DaleCurtis, vignesh
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reject vp8 video having alpha and image planes of different sizes. Previously we would accept malformed vp8 video files that had alpha and image planes with different dimensions. Now they result in a decode error. Also use the alpha image stride when copying the alpha plane, because it technically doesn't have to be the same as the image stride. BUG=449958 TEST=ffmpeg_regression_tests Committed: https://crrev.com/c1a91a8a6a7132c47a174054f0fb56cc3dc8c069 Cr-Commit-Position: refs/heads/master@{#312420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M media/ffmpeg/ffmpeg_regression_tests.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
watk
5 years, 8 months ago (2015-01-21 18:47:49 UTC) #2
vignesh
LGTM. thanks watk@. Although, you will need Dale's LGTM for media owners.
5 years, 8 months ago (2015-01-21 18:50:16 UTC) #3
DaleCurtis
lgtm
5 years, 8 months ago (2015-01-21 19:10:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858303002/1
5 years, 8 months ago (2015-01-21 20:01:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-01-21 20:25:26 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-01-21 20:27:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1a91a8a6a7132c47a174054f0fb56cc3dc8c069
Cr-Commit-Position: refs/heads/master@{#312420}

Powered by Google App Engine
This is Rietveld 408576698