Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 858213003: Clear pending exception on stack overflow in the parser (Closed)

Created:
5 years, 11 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clear pending exception on stack overflow in the parser BUG=450960 LOG=n Committed: https://crrev.com/9cce4ff2852d465d8319d47bba92405ce3990f2f Cr-Commit-Position: refs/heads/master@{#26390}

Patch Set 1 #

Patch Set 2 : Increase stacksize for arm #

Patch Set 3 : Try harder #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : 70 needed for arm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M src/runtime/runtime-internal.cc View 1 2 3 4 1 chunk +8 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-450960.js View 1 2 3 4 5 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 30 (14 generated)
Toon Verwaest
PTAL
5 years, 11 months ago (2015-01-22 13:44:26 UTC) #2
Igor Sheludko
lgtm
5 years, 11 months ago (2015-01-22 13:46:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858213003/20001
5 years, 11 months ago (2015-01-22 13:50:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2361) v8_win64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/1349)
5 years, 11 months ago (2015-01-22 14:11:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858213003/20001
5 years, 11 months ago (2015-01-22 15:30:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858213003/40001
5 years, 11 months ago (2015-01-22 15:33:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/881)
5 years, 11 months ago (2015-01-22 16:33:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858213003/40001
5 years, 11 months ago (2015-01-22 17:51:24 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/887)
5 years, 11 months ago (2015-01-22 18:52:06 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858213003/40001
5 years, 11 months ago (2015-01-27 09:56:21 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/964)
5 years, 11 months ago (2015-01-27 09:58:03 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858213003/80001
5 years, 10 months ago (2015-02-02 12:06:33 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/1095)
5 years, 10 months ago (2015-02-02 13:00:15 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858213003/100001
5 years, 10 months ago (2015-02-03 05:53:34 UTC) #28
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 10 months ago (2015-02-03 06:22:32 UTC) #29
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 06:22:45 UTC) #30
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/9cce4ff2852d465d8319d47bba92405ce3990f2f
Cr-Commit-Position: refs/heads/master@{#26390}

Powered by Google App Engine
This is Rietveld 408576698