DescriptionRevert of Eliminate components_unittests' dependence on chrome resources. (patchset #7 id:160001 of https://codereview.chromium.org/856163002/)
Reason for revert:
Speculative revert:
http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Mac&number=21828
Original issue's description:
> Eliminate components_unittests' dependence on chrome resources.
>
> This CL changes components_unittests to create its own pakfile rather than
> relying on the chrome pakfile. To do this it adds a repack step that repacks
> the pakfiles that components_unittests needs into a
> components_unittests_resources.pak file, and then loads that pakfile
> explicitly.
>
> This change means that components_unittests now passes after a clean build,
> whereas before it would fail due to missing resources.
>
> This is based on blundell's change: https://codereview.chromium.org/258043003/
>
> BUG=348563, 450464
> R=thakis@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/045c9bf1d36f35643a077891dedf24054f2032a3
TBR=blundell@chromium.org,thakis@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=348563, 450464
Committed: https://crrev.com/2c5518d7b7d3eb119588fea8e6c668076c8bcfed
Cr-Commit-Position: refs/heads/master@{#312321}
Patch Set 1 #
Created: 5 years, 11 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|