Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 858203002: Revert of Eliminate components_unittests' dependence on chrome resources. (Closed)

Created:
5 years, 11 months ago by sergeyv
Modified:
5 years, 11 months ago
Reviewers:
Nico, jam, blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Eliminate components_unittests' dependence on chrome resources. (patchset #7 id:160001 of https://codereview.chromium.org/856163002/) Reason for revert: Speculative revert: http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Mac&number=21828 Original issue's description: > Eliminate components_unittests' dependence on chrome resources. > > This CL changes components_unittests to create its own pakfile rather than > relying on the chrome pakfile. To do this it adds a repack step that repacks > the pakfiles that components_unittests needs into a > components_unittests_resources.pak file, and then loads that pakfile > explicitly. > > This change means that components_unittests now passes after a clean build, > whereas before it would fail due to missing resources. > > This is based on blundell's change: https://codereview.chromium.org/258043003/ > > BUG=348563, 450464 > R=thakis@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/045c9bf1d36f35643a077891dedf24054f2032a3 TBR=blundell@chromium.org,thakis@chromium.org,jam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=348563, 450464 Committed: https://crrev.com/2c5518d7b7d3eb119588fea8e6c668076c8bcfed Cr-Commit-Position: refs/heads/master@{#312321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -31 lines) Patch
M components/bookmarks/browser/bookmark_model_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/components_tests.gyp View 5 chunks +5 lines, -22 lines 0 comments Download
M components/components_unittests.isolate View 2 chunks +3 lines, -1 line 0 comments Download
M components/test/run_all_unittests.cc View 4 chunks +38 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sergeyv
Created Revert of Eliminate components_unittests' dependence on chrome resources.
5 years, 11 months ago (2015-01-21 13:09:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858203002/1
5 years, 11 months ago (2015-01-21 13:10:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 13:13:31 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 13:14:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c5518d7b7d3eb119588fea8e6c668076c8bcfed
Cr-Commit-Position: refs/heads/master@{#312321}

Powered by Google App Engine
This is Rietveld 408576698