Conservative blob bounds cleanup

Conservative blob bounds cleanup

* drop SK_SUPPORT_LEGACY_BLOB_BOUNDS
* remove horizontal & fully position tight bounds support (always using
  conservative bounds now)
* special-case horizontal run bounds logic to avoid unnecessary vertical
  min-maxing

R=reed@google.com,mtklein@google.com

Committed: https://skia.googlesource.com/skia/+/f9a40723f5d9bfe02cc60bedb5b956916e5cea01

[f(malita), 2015-01-29 19:19:38]

https://codereview.chromium.org/858153007/diff/1/src/core/SkTextBlob.cpp
File src/core/SkTextBlob.cpp (left):

https://codereview.chromium.org/858153007/diff/1/src/core/SkTextBlob.cpp#oldc...
src/core/SkTextBlob.cpp:313: return bounds;
Previously missing the run offset here.

[reed1, 2015-01-29 19:22:44]

do we need any unittests or otherwise to be sure we don't break these heuristics
(when to be tight -vs- conservative) in the future? Just asking.

lgtm

[f(malita), 2015-01-29 19:29:57]

On 2015/01/29 19:22:44, reed1 wrote:
> do we need any unittests or otherwise to be sure we don't break these
heuristics
> (when to be tight -vs- conservative) in the future? Just asking.
> 
> lgtm

We have a textblob GM which draws the bounds. So there's some coverage, although
it could probably use some more permutations.

[mtklein, 2015-01-29 19:52:03]

If I'm thinking right, the heuristic for tight vs conservative is "is
conservative easy to think about and implement"?  I don't see any way to make
the bounds of the  drawText()-like parts any better than measureText().

lgtm to me too, with a little suggestion on code organization

https://codereview.chromium.org/858153007/diff/1/src/core/SkTextBlob.cpp
File src/core/SkTextBlob.cpp (right):

https://codereview.chromium.org/858153007/diff/1/src/core/SkTextBlob.cpp#newc...
src/core/SkTextBlob.cpp:324: SkRect bounds = SkRect::MakeXYWH(glyphPos[0],
SkRect bounds;

switch(..) {
  case H:
  SkScalar l,r = points[0];
  min/max
  bounds = { l, y, r, y };
  break;

  case XY:
  bounds.set(points);
  break;

?

[f(malita), 2015-01-29 20:18:31]

https://codereview.chromium.org/858153007/diff/1/src/core/SkTextBlob.cpp
File src/core/SkTextBlob.cpp (right):

https://codereview.chromium.org/858153007/diff/1/src/core/SkTextBlob.cpp#newc...
src/core/SkTextBlob.cpp:324: SkRect bounds = SkRect::MakeXYWH(glyphPos[0],
On 2015/01/29 19:52:03, mtklein wrote:
> SkRect bounds;
> 
> switch(..) {
>   case H:
>   SkScalar l,r = points[0];
>   min/max
>   bounds = { l, y, r, y };
>   break;
> 
>   case XY:
>   bounds.set(points);
>   break;
> 
> ?

Done.

[f(malita), 2015-01-29 20:18:35]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-01-29 20:18:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/858153007/20001

[commit-bot: I haz the power, 2015-01-29 20:24:28]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f9a40723f5d9bfe02cc60bedb5b956916e5cea01