Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 858153005: Mark big generated tests as Slow so that they don't timeout. (Closed)

Created:
5 years, 10 months ago by Daniel Bratell
Modified:
5 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mark big generated tests as Slow so that they don't timeout. The html5lib testsuite has some large tests that need more than a few seconds to run. This patch marks all of these as [ Slow ] to avoid random timeouts. BUG=453312 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189192

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M LayoutTests/FlakyTests View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/SlowTests View 2 chunks +18 lines, -2 lines 0 comments Download
M LayoutTests/TestExpectations View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Daniel Bratell
Please take a look.
5 years, 10 months ago (2015-01-29 12:29:18 UTC) #2
Daniel Bratell
On 2015/01/29 12:29:18, Daniel Bratell wrote: > Please take a look. I've checked with jgraham, ...
5 years, 10 months ago (2015-01-29 12:35:05 UTC) #3
fs
lgtm
5 years, 10 months ago (2015-01-29 12:56:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858153005/1
5 years, 10 months ago (2015-01-29 13:30:13 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 14:52:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189192

Powered by Google App Engine
This is Rietveld 408576698