Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: sky/tools/debugger/debugger.cc

Issue 858103002: Remove [Client=] annotation from ServiceProvider (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: rebase for trybots (no code changes from ps2) Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tools/debugger/debugger.h ('k') | sky/tools/tester/test_runner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/debugger/debugger.cc
diff --git a/sky/tools/debugger/debugger.cc b/sky/tools/debugger/debugger.cc
index 6eaf7fe9196dd363140aee56d5c701a5681ce1f3..c540b15f937d4bcc2aebd9efa29e7f1d0713ba02 100644
--- a/sky/tools/debugger/debugger.cc
+++ b/sky/tools/debugger/debugger.cc
@@ -15,6 +15,7 @@ SkyDebugger::SkyDebugger()
content_(nullptr),
navigator_host_factory_(this),
weak_factory_(this) {
+ exposed_services_impl_.AddService(&navigator_host_factory_);
}
SkyDebugger::~SkyDebugger() {
@@ -45,8 +46,8 @@ bool SkyDebugger::ConfigureOutgoingConnection(
void SkyDebugger::OnEmbed(
mojo::View* root,
- mojo::ServiceProviderImpl* exported_services,
- scoped_ptr<mojo::ServiceProvider> imported_services) {
+ mojo::InterfaceRequest<mojo::ServiceProvider> services,
+ mojo::ServiceProviderPtr exposed_services) {
root_ = root;
root_->AddObserver(this);
@@ -64,13 +65,10 @@ void SkyDebugger::OnEmbed(
NavigateToURL(pending_url_);
}
-void SkyDebugger::Embed(
- const mojo::String& url,
- mojo::InterfaceRequest<mojo::ServiceProvider> service_provider) {
- scoped_ptr<mojo::ServiceProviderImpl> exported_services(
- new mojo::ServiceProviderImpl());
- // exported_services->AddService(TBD) -- no exported services for now.
- content_->Embed(url, exported_services.Pass());
+void SkyDebugger::Embed(const mojo::String& url,
+ mojo::InterfaceRequest<mojo::ServiceProvider> services,
+ mojo::ServiceProviderPtr exposed_services) {
+ content_->Embed(url, nullptr, nullptr);
}
void SkyDebugger::OnViewManagerDisconnected(mojo::ViewManager* view_manager) {
@@ -97,10 +95,9 @@ void SkyDebugger::NavigateToURL(const mojo::String& url) {
// embedded into the view and content_ created.
// Just save the last one.
if (content_) {
- scoped_ptr<mojo::ServiceProviderImpl> exported_services(
- new mojo::ServiceProviderImpl());
- exported_services->AddService(&navigator_host_factory_);
- viewer_services_ = content_->Embed(url, exported_services.Pass());
+ mojo::ServiceProviderPtr exposed_services;
+ exposed_services_impl_.Bind(GetProxy(&exposed_services));
+ content_->Embed(url, GetProxy(&viewer_services_), exposed_services.Pass());
} else {
pending_url_ = url;
}
« no previous file with comments | « sky/tools/debugger/debugger.h ('k') | sky/tools/tester/test_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698