mojo/services/view_manager/public/cpp/view.h - Issue 858103002: Remove [Client=] annotation from ServiceProvider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/public/cpp/view.h

Issue 858103002: Remove [Client=] annotation from ServiceProvider (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: rebase for trybots (no code changes from ps2) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/view_manager/public/cpp/view.h

diff --git a/mojo/services/view_manager/public/cpp/view.h b/mojo/services/view_manager/public/cpp/view.h

index 5e4cc7339e0e9eff0f6b84774c020b9d47169d9e..1215a3b4f234981ae513192cb96215d4daa57012 100644

--- a/mojo/services/view_manager/public/cpp/view.h

+++ b/mojo/services/view_manager/public/cpp/view.h

@@ -124,11 +124,9 @@ class View {

// Embedding.

void Embed(const String& url);

- scoped_ptr<ServiceProvider> Embed(

- const String& url,

- scoped_ptr<ServiceProviderImpl> exported_services);

void Embed(const String& url,

- InterfaceRequest<ServiceProvider> service_provider);

+ InterfaceRequest<ServiceProvider> services,

+ ServiceProviderPtr exposed_services);

protected:

// This class is subclassed only by test classes that provide a public ctor.