Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: mojo/services/view_manager/public/cpp/view.h

Issue 858103002: Remove [Client=] annotation from ServiceProvider (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/public/cpp/view.h
diff --git a/mojo/services/view_manager/public/cpp/view.h b/mojo/services/view_manager/public/cpp/view.h
index 5e4cc7339e0e9eff0f6b84774c020b9d47169d9e..1215a3b4f234981ae513192cb96215d4daa57012 100644
--- a/mojo/services/view_manager/public/cpp/view.h
+++ b/mojo/services/view_manager/public/cpp/view.h
@@ -124,11 +124,9 @@ class View {
// Embedding.
void Embed(const String& url);
- scoped_ptr<ServiceProvider> Embed(
- const String& url,
- scoped_ptr<ServiceProviderImpl> exported_services);
void Embed(const String& url,
- InterfaceRequest<ServiceProvider> service_provider);
+ InterfaceRequest<ServiceProvider> services,
sky 2015/01/21 16:59:00 This is subtle. It's worth documenting the differe
jamesr 2015/01/21 18:51:40 It's the same as in application.mojom and the docu
+ ServiceProviderPtr exposed_services);
protected:
// This class is subclassed only by test classes that provide a public ctor.

Powered by Google App Engine
This is Rietveld 408576698