Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Side by Side Diff: mojo/services/view_manager/public/cpp/tests/view_manager_unittest.cc

Issue 858103002: Remove [Client=] annotation from ServiceProvider (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: rebase for trybots (no code changes from ps2) Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/services/view_manager/public/cpp/view_manager.h" 5 #include "mojo/services/view_manager/public/cpp/view_manager.h"
6 6
7 #include "base/auto_reset.h" 7 #include "base/auto_reset.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "mojo/public/cpp/application/application_connection.h" 10 #include "mojo/public/cpp/application/application_connection.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 void OnApplicationError(ApplicationManager* manager, 74 void OnApplicationError(ApplicationManager* manager,
75 const GURL& url) override {} 75 const GURL& url) override {}
76 76
77 bool ConfigureIncomingConnection(ApplicationConnection* connection) override { 77 bool ConfigureIncomingConnection(ApplicationConnection* connection) override {
78 connection->AddService(view_manager_client_factory_.get()); 78 connection->AddService(view_manager_client_factory_.get());
79 return true; 79 return true;
80 } 80 }
81 81
82 // Overridden from ViewManagerDelegate: 82 // Overridden from ViewManagerDelegate:
83 void OnEmbed(View* root, 83 void OnEmbed(View* root,
84 ServiceProviderImpl* exported_services, 84 InterfaceRequest<ServiceProvider> services,
85 scoped_ptr<ServiceProvider> imported_services) override { 85 ServiceProviderPtr exposed_services) override {
86 callback_.Run(root); 86 callback_.Run(root);
87 } 87 }
88 void OnViewManagerDisconnected(ViewManager* view_manager) override {} 88 void OnViewManagerDisconnected(ViewManager* view_manager) override {}
89 89
90 ScopedVector<ApplicationImpl> apps_; 90 ScopedVector<ApplicationImpl> apps_;
91 LoadedCallback callback_; 91 LoadedCallback callback_;
92 scoped_ptr<ViewManagerClientFactory> view_manager_client_factory_; 92 scoped_ptr<ViewManagerClientFactory> view_manager_client_factory_;
93 93
94 DISALLOW_COPY_AND_ASSIGN(ConnectApplicationLoader); 94 DISALLOW_COPY_AND_ASSIGN(ConnectApplicationLoader);
95 }; 95 };
(...skipping 547 matching lines...) Expand 10 before | Expand all | Expand 10 after
643 643
644 // TODO(beng): tests for focus: 644 // TODO(beng): tests for focus:
645 // - focus between two views known to a connection 645 // - focus between two views known to a connection
646 // - focus between views unknown to one of the connections. 646 // - focus between views unknown to one of the connections.
647 // - focus between views unknown to either connection. 647 // - focus between views unknown to either connection.
648 648
649 // TODO(sky): need test of root being destroyed with existing views. See 649 // TODO(sky): need test of root being destroyed with existing views. See
650 // 434555 for specific case. 650 // 434555 for specific case.
651 651
652 } // namespace mojo 652 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/services/view_manager/public/cpp/lib/view_manager_context.cc ('k') | mojo/services/view_manager/public/cpp/view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698