Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 858093004: Roll google-toolbax-for-mac a095262:17eee69. (Closed)

Created:
5 years, 11 months ago by erikchen
Modified:
5 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll google-toolbax-for-mac a095262:17eee69 (svn 685:703). Summary of changes available at: https://chromium.googlesource.com/external/google-toolbox-for-mac.git/+log/a095262..17eee69 Notable changes include: 17eee69 Make GTMSMJobRemove() have the same behavior on OSX 10.10+ as it has on previous OSX versions. BUG=390276 Committed: https://crrev.com/3bef4c7d396928c337fa1dde4864980eb7dc381c Cr-Commit-Position: refs/heads/master@{#313362}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments from mark. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
erikchen
mark: Please review.
5 years, 11 months ago (2015-01-27 19:10:51 UTC) #2
Mark Mentovai
LGTM https://codereview.chromium.org/858093004/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/858093004/diff/1/DEPS#newcode85 DEPS:85: 'google_toolbox_for_mac_revision': '17eee6933bb4a978bf045ef1b12fc68f15b08cd2', The upstream for GTM is in ...
5 years, 11 months ago (2015-01-27 19:21:27 UTC) #3
erikchen
https://codereview.chromium.org/858093004/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/858093004/diff/1/DEPS#newcode85 DEPS:85: 'google_toolbox_for_mac_revision': '17eee6933bb4a978bf045ef1b12fc68f15b08cd2', On 2015/01/27 19:21:26, Mark Mentovai wrote: > ...
5 years, 11 months ago (2015-01-27 19:50:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858093004/20001
5 years, 11 months ago (2015-01-27 19:51:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 21:41:56 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 21:43:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3bef4c7d396928c337fa1dde4864980eb7dc381c
Cr-Commit-Position: refs/heads/master@{#313362}

Powered by Google App Engine
This is Rietveld 408576698