Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 858093002: Update the network service from the Mojo repo. (Closed)

Created:
5 years, 11 months ago by ppi
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, qsr, blundell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the network service from the Mojo repo. The corresponding Mojo change at https://codereview.chromium.org/832683005/ changes the source-of-truth for the network service from the Mojo repo to Chromium. BUG=450356 TBR=darin@chromium.org Committed: https://crrev.com/0a2a1898d00213dc6746a6bfc08c28aa314ba65f Cr-Commit-Position: refs/heads/master@{#312361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+518 lines, -80 lines) Patch
M mojo/services/network/BUILD.gn View 2 chunks +96 lines, -25 lines 0 comments Download
M mojo/services/network/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + mojo/services/network/android_hooks.cc View 1 chunk +12 lines, -8 lines 0 comments Download
M mojo/services/network/network_context.h View 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/services/network/network_context.cc View 2 chunks +18 lines, -6 lines 0 comments Download
M mojo/services/network/network_service.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/network/network_service_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/services/network/tcp_connected_socket_impl.cc View 5 chunks +10 lines, -6 lines 0 comments Download
A + mojo/services/network/udp_socket_apptest.cc View 6 chunks +17 lines, -18 lines 0 comments Download
M mojo/services/network/url_loader_impl.h View 5 chunks +14 lines, -3 lines 0 comments Download
M mojo/services/network/url_loader_impl.cc View 14 chunks +54 lines, -13 lines 0 comments Download
A mojo/services/network/url_loader_impl_apptest.cc View 1 chunk +282 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ppi
Hi James, ptal. This is a mechanical update from the ToT mojo. Note that during ...
5 years, 11 months ago (2015-01-21 02:02:25 UTC) #2
jamesr
lgtm
5 years, 11 months ago (2015-01-21 02:06:02 UTC) #3
ppi
Thanks, adding TBR=darin for DEPS owners check.
5 years, 11 months ago (2015-01-21 02:16:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858093002/1
5 years, 11 months ago (2015-01-21 02:19:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-21 14:25:23 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 14:26:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a2a1898d00213dc6746a6bfc08c28aa314ba65f
Cr-Commit-Position: refs/heads/master@{#312361}

Powered by Google App Engine
This is Rietveld 408576698