Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: sky/engine/core/css/resolver/StyleResolver.h

Issue 858073003: Prune the API of StyleResolver. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/core/css/resolver/StyleResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/css/resolver/StyleResolver.h
diff --git a/sky/engine/core/css/resolver/StyleResolver.h b/sky/engine/core/css/resolver/StyleResolver.h
index f8d3929400d615cb455eb2c0637358cf4f6bd781..3b774628c5bc817d7f91f11cea0a490a6658905b 100644
--- a/sky/engine/core/css/resolver/StyleResolver.h
+++ b/sky/engine/core/css/resolver/StyleResolver.h
@@ -76,17 +76,11 @@ public:
static PassRefPtr<RenderStyle> styleForDocument(Document&);
- // FIXME: This only has 5 callers and should be removed. Callers should be explicit about
- // their dependency on Document* instead of grabbing one through StyleResolver.
- Document& document() { return *m_document; }
-
void styleTreeResolveScopedKeyframesRules(const Element*, Vector<RawPtr<ScopedStyleResolver>, 8>&);
// |properties| is an array with |count| elements.
void applyPropertiesToStyle(const CSSPropertyValue* properties, size_t count, RenderStyle*);
- bool mediaQueryAffectedByViewportChange() const;
-
// FIXME: Rename to reflect the purpose, like didChangeFontSize or something.
void invalidateMatchedPropertiesCache();
@@ -104,9 +98,6 @@ public:
void disableStats();
void printStats();
- unsigned accessCount() const { return m_accessCount; }
- void didAccess() { ++m_accessCount; }
-
private:
// FIXME: This should probably go away, folded into FontBuilder.
void updateFont(StyleResolverState&);
@@ -141,16 +132,13 @@ private:
MatchedPropertiesCache m_matchedPropertiesCache;
- RawPtr<Document> m_document;
+ Document& m_document;
StyleSharingList m_styleSharingList;
OwnPtr<StyleResolverStats> m_styleResolverStats;
OwnPtr<StyleResolverStats> m_styleResolverStatsTotals;
unsigned m_styleResolverStatsSequence;
-
- // Use only for Internals::updateStyleAndReturnAffectedElementCount.
- unsigned m_accessCount;
};
} // namespace blink
« no previous file with comments | « no previous file | sky/engine/core/css/resolver/StyleResolver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698