Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 858053003: Minor changes to still-unfinal chrome://settings/autofill wallet UI (Closed)

Created:
5 years, 11 months ago by Evan Stade
Modified:
5 years, 11 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor changes to still-unfinal chrome://settings/autofill wallet UI 1. add checkbox 2. add new pref 3. move checkbox to top of dialog (near mac contact book checkbox) BUG=446698 Committed: https://crrev.com/29e41141428199096695bcf97833403214da808a Cr-Commit-Position: refs/heads/master@{#312532}

Patch Set 1 #

Patch Set 2 : actual pref #

Total comments: 2

Patch Set 3 : dont return void and add include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -26 lines) Patch
M chrome/browser/autofill/android/personal_data_manager_android.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.html View 1 3 chunks +33 lines, -20 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.js View 1 chunk +4 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/common/autofill_pref_names.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/common/autofill_pref_names.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Evan Stade
5 years, 11 months ago (2015-01-21 01:37:26 UTC) #2
please use gerrit instead
lgtm
5 years, 11 months ago (2015-01-21 01:42:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858053003/1
5 years, 11 months ago (2015-01-21 01:44:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/16534)
5 years, 11 months ago (2015-01-21 02:48:04 UTC) #7
Evan Stade
had to actually add a pref to get past the try servers. ptal
5 years, 11 months ago (2015-01-22 00:47:04 UTC) #10
please use gerrit instead
https://codereview.chromium.org/858053003/diff/20001/chrome/browser/autofill/android/personal_data_manager_android.cc File chrome/browser/autofill/android/personal_data_manager_android.cc (right): https://codereview.chromium.org/858053003/diff/20001/chrome/browser/autofill/android/personal_data_manager_android.cc#newcode362 chrome/browser/autofill/android/personal_data_manager_android.cc:362: return GetPrefs()->SetBoolean(autofill::prefs::kAutofillWalletImportEnabled, no need for "return" here.
5 years, 11 months ago (2015-01-22 01:02:54 UTC) #11
Evan Stade
https://codereview.chromium.org/858053003/diff/20001/chrome/browser/autofill/android/personal_data_manager_android.cc File chrome/browser/autofill/android/personal_data_manager_android.cc (right): https://codereview.chromium.org/858053003/diff/20001/chrome/browser/autofill/android/personal_data_manager_android.cc#newcode362 chrome/browser/autofill/android/personal_data_manager_android.cc:362: return GetPrefs()->SetBoolean(autofill::prefs::kAutofillWalletImportEnabled, On 2015/01/22 01:02:53, Rouslan Solomakhin wrote: > ...
5 years, 11 months ago (2015-01-22 01:09:04 UTC) #12
please use gerrit instead
lgtm
5 years, 11 months ago (2015-01-22 01:10:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858053003/40001
5 years, 11 months ago (2015-01-22 01:12:56 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-22 02:24:55 UTC) #16
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 02:26:21 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/29e41141428199096695bcf97833403214da808a
Cr-Commit-Position: refs/heads/master@{#312532}

Powered by Google App Engine
This is Rietveld 408576698