Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 858003002: Enable find-missing-symbols-at-link-time for android too. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, pasko, Fabrice (no longer in Chrome)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable find-missing-symbols-at-link-time for android too. BUG=371125 Committed: https://crrev.com/733f0be82365d13eb8944a5e860c7f8d7358f4f4 Cr-Commit-Position: refs/heads/master@{#312272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
This seems to just work, after the bits that made desktop linux work (see bug).
5 years, 11 months ago (2015-01-20 18:48:33 UTC) #2
Nico
(might give your upstream bot trouble, but should be relatively easy to fix)
5 years, 11 months ago (2015-01-20 18:48:56 UTC) #3
cjhopman
lgtm
5 years, 11 months ago (2015-01-20 20:52:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/858003002/1
5 years, 11 months ago (2015-01-20 20:56:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 21:00:42 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 21:01:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/733f0be82365d13eb8944a5e860c7f8d7358f4f4
Cr-Commit-Position: refs/heads/master@{#312272}

Powered by Google App Engine
This is Rietveld 408576698