Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 857953002: ensure trace extension works from optimized code when profiler is not enabled (Closed)

Created:
5 years, 11 months ago by dcarney
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ensure trace extension works from optimized code when profiler is not enabled BUG= Committed: https://crrev.com/cae3a43d5bfdc565bd98c86be08305d411e6b690 Cr-Commit-Position: refs/heads/master@{#26160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M test/cctest/trace-extension.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-20 13:24:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/857953002/1
5 years, 11 months ago (2015-01-20 13:26:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-20 14:14:36 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 14:14:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cae3a43d5bfdc565bd98c86be08305d411e6b690
Cr-Commit-Position: refs/heads/master@{#26160}

Powered by Google App Engine
This is Rietveld 408576698