Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: src/mips/assembler-mips.h

Issue 85793002: Drop unused Assembler::set_external_target_at() method. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/assembler-ia32.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 519 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 // This sets the branch destination (which gets loaded at the call address). 530 // This sets the branch destination (which gets loaded at the call address).
531 // This is for calls and branches within generated code. The serializer 531 // This is for calls and branches within generated code. The serializer
532 // has already deserialized the lui/ori instructions etc. 532 // has already deserialized the lui/ori instructions etc.
533 inline static void deserialization_set_special_target_at( 533 inline static void deserialization_set_special_target_at(
534 Address instruction_payload, Address target) { 534 Address instruction_payload, Address target) {
535 set_target_address_at( 535 set_target_address_at(
536 instruction_payload - kInstructionsFor32BitConstant * kInstrSize, 536 instruction_payload - kInstructionsFor32BitConstant * kInstrSize,
537 target); 537 target);
538 } 538 }
539 539
540 // This sets the branch destination.
541 // This is for calls and branches to runtime code.
542 inline static void set_external_target_at(Address instruction_payload,
543 Address target) {
544 set_target_address_at(instruction_payload, target);
545 }
546
547 // Size of an instruction. 540 // Size of an instruction.
548 static const int kInstrSize = sizeof(Instr); 541 static const int kInstrSize = sizeof(Instr);
549 542
550 // Difference between address of current opcode and target address offset. 543 // Difference between address of current opcode and target address offset.
551 static const int kBranchPCOffset = 4; 544 static const int kBranchPCOffset = 4;
552 545
553 // Here we are patching the address in the LUI/ORI instruction pair. 546 // Here we are patching the address in the LUI/ORI instruction pair.
554 // These values are used in the serialization process and must be zero for 547 // These values are used in the serialization process and must be zero for
555 // MIPS platform, as Code, Embedded Object or External-reference pointers 548 // MIPS platform, as Code, Embedded Object or External-reference pointers
556 // are split across two consecutive instructions and don't exist separately 549 // are split across two consecutive instructions and don't exist separately
(...skipping 684 matching lines...) Expand 10 before | Expand all | Expand 10 after
1241 class EnsureSpace BASE_EMBEDDED { 1234 class EnsureSpace BASE_EMBEDDED {
1242 public: 1235 public:
1243 explicit EnsureSpace(Assembler* assembler) { 1236 explicit EnsureSpace(Assembler* assembler) {
1244 assembler->CheckBuffer(); 1237 assembler->CheckBuffer();
1245 } 1238 }
1246 }; 1239 };
1247 1240
1248 } } // namespace v8::internal 1241 } } // namespace v8::internal
1249 1242
1250 #endif // V8_ARM_ASSEMBLER_MIPS_H_ 1243 #endif // V8_ARM_ASSEMBLER_MIPS_H_
OLDNEW
« no previous file with comments | « src/ia32/assembler-ia32.h ('k') | src/x64/assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698